Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

kubectl kustomize versioning #797

Closed
nicks opened this issue Jan 8, 2020 · 22 comments
Closed

kubectl kustomize versioning #797

nicks opened this issue Jan 8, 2020 · 22 comments
Assignees
@seans3 @pwittrock
Labels
area/kubectl kind/feature Categorizes issue or PR as related to a new feature. lifecycle/frozen Indicates that an issue or PR should not be auto-closed due to staleness. priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. sig/cli Categorizes an issue or PR as relevant to SIG CLI.

Comments

@nicks
Copy link

nicks commented Jan 8, 2020 •
edited
Loading

Expected behavior:

kubectl kustomize version

should print information about the version of Kustomize templates that kubectl kustomize accepts

Actual behavior

kubectl kustomize version

doesn't work.

The kubectl command only accepts kustomize version 2+, but the main kustomize repo is on version 3+. This has caused some confusion for our users, because they thought that they should be using the "new way" of preferring kubectl kustomize over kustomize

Obviously, we could work around this by keeping a map from kubectl versions to compatible kustomize versions, but it would be nice if we could get this info from kubectl kustomize

Relatedly, what's the plan for upgrading kubectl to kustomize 3?
@nicks nicks mentioned this issue Jan 8, 2020
Open
@dlipovetsky
Copy link
Contributor

/cc @kubernetes/sig-cli-feature-requests

@k8s-ci-robot k8s-ci-robot added sig/cli Categorizes an issue or PR as relevant to SIG CLI. kind/feature Categorizes issue or PR as related to a new feature. labels Jan 9, 2020
@ofek ofek mentioned this issue Jan 12, 2020
Closed
@dlipovetsky
Copy link
Contributor

Regardless of the future of kubectl kustomize, it would help to know which kustomize version is used.

@ricochet
Copy link
Contributor

Please close and reopen this on kustomize.

@nicks nicks mentioned this issue Jan 22, 2020
Closed
@nicks
Copy link
Author

nicks commented Jan 22, 2020

great filed as kubernetes-sigs/kustomize#2142.

though i think the change has to happen in this repo, since it's about what subcommands are registered? https://github.com/kubernetes/kubectl/blob/master/pkg/cmd/kustomize/kustomize.go#L59

@fejta-bot
Copy link

Issues go stale after 90d of inactivity.
Mark the issue as fresh with /remove-lifecycle stale.
Stale issues rot after an additional 30d of inactivity and eventually close.

If this issue is safe to close now please do so with /close.

Send feedback to sig-testing, kubernetes/test-infra and/or fejta.
/lifecycle stale

@k8s-ci-robot k8s-ci-robot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Apr 21, 2020
@seans3
Copy link
Contributor

seans3 commented Apr 21, 2020

/remove-lifecycle stale

@k8s-ci-robot k8s-ci-robot removed the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Apr 21, 2020
@seans3
Copy link
Contributor

seans3 commented Apr 21, 2020

/sig cli
/area kubectl

@seans3
Copy link
Contributor

seans3 commented Apr 23, 2020

/assign

@fejta-bot
Copy link

Issues go stale after 90d of inactivity.
Mark the issue as fresh with /remove-lifecycle stale.
Stale issues rot after an additional 30d of inactivity and eventually close.

If this issue is safe to close now please do so with /close.

Send feedback to sig-testing, kubernetes/test-infra and/or fejta.
/lifecycle stale

@k8s-ci-robot k8s-ci-robot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Jul 22, 2020
@greenstatic
Copy link

/remove-lifecycle stale

@k8s-ci-robot k8s-ci-robot removed the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Jul 22, 2020
@eddiezane
Copy link
Member

/priority important-soon
/assign @pwittrock

@k8s-ci-robot k8s-ci-robot added the priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. label Jul 22, 2020
@eddiezane eddiezane mentioned this issue Jul 22, 2020
Closed
@pwittrock
Copy link
Member

pwittrock commented Jul 22, 2020 •
edited
Loading

FYI: updating the FAQ with this:

kubernetes-sigs/kustomize#2749

TLDR: This is blocked on either moving kubectl into its own repo, or changing its dependencies. ETA k8s ~1.20.

The adoption of go modules in the kubernetes/kubernetes repo broke the update process for kustomize.
This is due to the kustomize libraries depending on the kubernetes apimachinery libraries, which are
published out of the kubernetes staging directory.

2 pieces of work are underway which will allow kustomize to be updated in kubectl:

  • migrating kubectl out of kubernetes/kubernetes (expected Kubernetes ~1.20)
  • migrating kustomize off of the apimachinery libraries (expected Kuberntes ~1.20)

Once either of these issues is resolved we will then update kubectl with the latest kustomize version.

@eddiezane eddiezane mentioned this issue Oct 12, 2020
Closed
@fejta-bot
Copy link

Issues go stale after 90d of inactivity.
Mark the issue as fresh with /remove-lifecycle stale.
Stale issues rot after an additional 30d of inactivity and eventually close.

If this issue is safe to close now please do so with /close.

Send feedback to sig-testing, kubernetes/test-infra and/or fejta.
/lifecycle stale

@k8s-ci-robot k8s-ci-robot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Oct 20, 2020
@pierluigilenoci
Copy link

/remove-lifecycle stale

@k8s-ci-robot k8s-ci-robot removed the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Oct 21, 2020
@fejta-bot
Copy link

Issues go stale after 90d of inactivity.
Mark the issue as fresh with /remove-lifecycle stale.
Stale issues rot after an additional 30d of inactivity and eventually close.

If this issue is safe to close now please do so with /close.

Send feedback to sig-testing, kubernetes/test-infra and/or fejta.
/lifecycle stale

@k8s-ci-robot k8s-ci-robot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Jan 19, 2021
@seans3
Copy link
Contributor

seans3 commented Jan 19, 2021

/remove-lifecycle stale
/lifecycle frozen

@k8s-ci-robot k8s-ci-robot added lifecycle/frozen Indicates that an issue or PR should not be auto-closed due to staleness. and removed lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. labels Jan 19, 2021
@MaisaDaoud
Copy link

kubectl apply -k doesnt work with kustomization.yaml with generators and transformers. Any help

@MaisaDaoud
Copy link

MaisaDaoud commented Feb 15, 2021 •
edited
Loading

update: the built in kustomize doesn't work with generators and transfomers plugins (as per mentioned in one of the open questions). As I was trying it within azure environment, I reckon the best place to install kustomize and set the path in azure is https://www.kubeflow.org/docs/other-guides/kustomize/ ... solved my issue. thanks

@KrisJohnstone
Copy link

RE: Version Upgrade for those whom stumble across this:
kubernetes/kubernetes#98946

@eddiezane
Copy link
Member

Looks like kubectl kustomize --version didn't make it in with the 1.21 changes.

@natasha41575 is this something y'all can take on?

@natasha41575
Copy link
Contributor

will discuss with @monopole

@eddiezane
Copy link
Member

Let's track this at kubernetes-sigs/kustomize#1424

/close

@jmcudd jmcudd mentioned this issue Nov 17, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@seans3 seans3

@pwittrock pwittrock

Labels
area/kubectl kind/feature Categorizes issue or PR as related to a new feature. lifecycle/frozen Indicates that an issue or PR should not be auto-closed due to staleness. priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. sig/cli Categorizes an issue or PR as relevant to SIG CLI.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests