--deployment-config flag is not necessary

[surajnarwade]

even when we don't provide --deployment-config flag, kompose creates deploymentconfig, so it doesn't make any sense to have this flag.

[cdrage]

@surajnarwade it's used to disable --deployment-config being created

[surajnarwade]

without flag

$ kompose convert --provider=openshift
INFO OpenShift file "foo-service.yaml" created    
INFO OpenShift file "foo-deploymentconfig.yaml" created 
INFO OpenShift file "foo-imagestream.yaml" created

and with flag,

 $ kompose convert --provider=openshift --deployment-config
INFO OpenShift file "foo-service.yaml" created    
INFO OpenShift file "foo-deploymentconfig.yaml" created 
INFO OpenShift file "foo-imagestream.yaml" created 

@cdrage ^^

[cdrage]

@surajnarwade You're using it wrong, it's --deployment-config false would work. It's true by default

[surajnarwade]

$ kompose convert --provider=openshift --deployment-config=false
INFO OpenShift file "foo-service.yaml" created    
INFO OpenShift file "foo-deploymentconfig.yaml" created 
INFO OpenShift file "foo-imagestream.yaml" created

[cdrage]

Ah crap, it's a bug then. Let's fix this.

[surajnarwade]

@cdrage , what's the use case for disabling deployment-config ?

[fejta-bot]

Issues go stale after 90d of inactivity.
Mark the issue as fresh with /remove-lifecycle stale.
Stale issues rot after an additional 30d of inactivity and eventually close.

Prevent issues from auto-closing with an /lifecycle frozen comment.

If this issue is safe to close now please do so with /close.

Send feedback to sig-testing, kubernetes/test-infra and/or @fejta.
/lifecycle stale

[fejta-bot]

Stale issues rot after 30d of inactivity.
Mark the issue as fresh with /remove-lifecycle rotten.
Rotten issues close after an additional 30d of inactivity.

If this issue is safe to close now please do so with /close.

Send feedback to sig-testing, kubernetes/test-infra and/or fejta.
/lifecycle rotten
/remove-lifecycle stale

[cdrage]

/remove-lifecycle rotten

[fejta-bot]

Issues go stale after 90d of inactivity.
Mark the issue as fresh with /remove-lifecycle stale.
Stale issues rot after an additional 30d of inactivity and eventually close.

If this issue is safe to close now please do so with /close.

Send feedback to sig-testing, kubernetes/test-infra and/or fejta.
/lifecycle stale

[cdrage]

Yeah, this is deprecated. I'm going to close this. We've deprecated this for --controller