Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

kompose fails to build on ppc64 and ppc64le arches due to old sys/unix vendor package #532

Closed
sinnykumari opened this issue Mar 31, 2017 · 2 comments

Comments

@sinnykumari
Copy link

sinnykumari commented Mar 31, 2017

Hi,

Kompose-v0.4.0 fails to build on ppc64(le) architectures with following error message:
# github.com/kubernetes-incubator/kompose/vendor/github.com/fsnotify/fsnotify
src/github.com/kubernetes-incubator/kompose/vendor/github.com/fsnotify/fsnotify/inotify_poller.go:48: undefined: unix.Pipe2

It seems that vendored sys/unix package is old because /vendor/golang.org/x/sys/unix/syscall_linux_ppc64x.go doesn't contain definition of function Pipe2 for ppc64x while upstream has the fixes available golang/sys@b776ec3#diff-ed5775d43461429a9a5247567c3c9fd9R117 .

I built locally and in koji by replacing /vendor/golang.org/x/sys/unix content with https://github.com/golang/sys/tree/master/unix/ and it builds successfully.

I tried to update sys package in kompose using "glide get golang.org/x/sys/unix" , didn't use glide up because glide.yaml doesn't have entry for sys/unix . It doesn't seem to go successfully for me, details are at https://paste.fedoraproject.org/paste/nPuAB0vbRIXDwIqyA0YWE15M1UNdIGYhyRLivL9gydE=
.

Reference

Complete build log - https://kojipkgs.fedoraproject.org//work/tasks/1264/18671264/build.log
Failed koji build link - https://koji.fedoraproject.org/koji/taskinfo?taskID=18671235
Successful koji build link after sys/unix update - https://koji.fedoraproject.org/koji/taskinfo?taskID=18697032

@dustymabe
Copy link
Contributor

ping @kadel @surajssd - this is why we can't get 0.4.0 out into Fedora right now. It looks like we need to update golang.org/x/sys/unix to latest version.

@cdrage
Copy link
Member

cdrage commented Mar 31, 2017

Hey @dustymabe @sinnykumari
I've updated this in #529

Give it your LGTM and this issue will be fixed :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants