wrong git revision number in version output

[kadel]

code revision from which binary is build is wrong.

▶ make
go build -ldflags="-w -X github.com/kubernetes-incubator/kompose/version.GITCOMMIT=be042c7" -o kompose main.go

▶ ./kompose version
0.2.0 (64433fd)

▶ git rev-parse --short HEAD
be042c7

kompose version should output same revision as current source.
It looks like there is commitid inside version.go Shouldn't this show HEAD as default or something like this?

What if we get rid of this? Do we need to show commit id in version output?

[cdrage]

Ahhh.. I changed it to show the Git Commit for the current version instead of HEAD... Should we just get rid of this instead?

[surajssd]

@kadel you re-opened this? Why is that so?

[kadel]

I hoped that we might discuss here if maybe we wan't to get rid of whole commitid (showing commit id in kompose version output)

[cdrage]

@kadel Should we close this? Having the hash in the ID has actually helped in terms of releases as well as troubleshooting (whether or not it's been compiled locally against master, etc.)

[fejta-bot]

Issues go stale after 90d of inactivity.
Mark the issue as fresh with /remove-lifecycle stale.
Stale issues rot after an additional 30d of inactivity and eventually close.

Prevent issues from auto-closing with an /lifecycle frozen comment.

If this issue is safe to close now please do so with /close.

Send feedback to sig-testing, kubernetes/test-infra and/or @fejta.
/lifecycle stale