Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Parsing environment variables with : #196

Closed
ngtuna opened this issue Oct 9, 2016 · 0 comments · Fixed by #197
Closed

Parsing environment variables with : #196

ngtuna opened this issue Oct 9, 2016 · 0 comments · Fixed by #197
Assignees
@ngtuna
Labels
kind/bug Categorizes issue or PR as related to a bug.

Comments

@ngtuna
Copy link
Contributor

ngtuna commented Oct 9, 2016

libcompose could support both separate characters : and = in envvar because docker config object accepted them. However, kompose doesn't rely on docker but libcompose config object. Thus, kompose can only support = at this moment.

Related issue: #173. In the hygieia example, there are envvars with : and kompose getting panic.
@ngtuna ngtuna added the bug label Oct 9, 2016
@ngtuna ngtuna self-assigned this Oct 9, 2016
@ngtuna ngtuna mentioned this issue Oct 10, 2016
Merged
@kadel kadel added kind/bug Categorizes issue or PR as related to a bug. and removed bug labels Oct 19, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ngtuna ngtuna

Labels
kind/bug Categorizes issue or PR as related to a bug.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

support both : and = as compose envvar separators ngtuna/kompose
2 participants
@kadel @ngtuna