Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

script/godep-restore.sh doesn't seem to work correctly #194

Closed
ngtuna opened this issue Oct 8, 2016 · 4 comments
Closed

script/godep-restore.sh doesn't seem to work correctly #194

ngtuna opened this issue Oct 8, 2016 · 4 comments
Labels
kind/libs

Comments

@ngtuna
Copy link
Contributor

ngtuna commented Oct 8, 2016

I tried running script/godep-restore.sh in a fresh $GOPATH, and then removed Godeps and vendor folders and then running godep save ./... in order to save them again. The new born Godeps.json looks quite different with the current one we have in upstream.
@ngtuna
Copy link
Contributor Author

ngtuna commented Oct 8, 2016

However, building kompose with the new generated vendor/ run successfully. Many packages have been removed.

@kadel
Copy link
Member

kadel commented Oct 8, 2016

This is not godep fault but ours.
We let vendor get out of sync. Every time we add or remove import we should run save.
We don't do that so we have few unused libs in vendor.

@ngtuna
Copy link
Contributor Author

ngtuna commented Oct 8, 2016

Right. So I am going to update vendor

@ngtuna ngtuna mentioned this issue Oct 9, 2016
Merged
@ngtuna
Copy link
Contributor Author

ngtuna commented Oct 10, 2016

closed via #195

@ngtuna ngtuna closed this as completed Oct 10, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
kind/libs
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@kadel @ngtuna