Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Consolidate filenames in tests from docker-compose[.*].y[a]ml to compose[.*].yaml #1812

Closed
martinjirku opened this issue Jan 18, 2024 · 0 comments · Fixed by #1834
Closed
Labels
kind/feature Categorizes issue or PR as related to a new feature.

Comments

@martinjirku
Copy link
Contributor

What would you like to be added?

We should consolidate and enhance filenames in tests, so we will remove "docker-" prefix from docker-compose[.*].y[a]ml to docker-compose[.*].yaml. While changing the files names, we need to update the references to these files.

The list of files which needs to change its name:

harry@fedora:~/dev/kompose$ find . -name "docker-compose*"
./client/testdata/docker-compose-profiles.yaml
./client/testdata/docker-compose.yaml
./script/test/fixtures/buildargs/docker-compose.yml
./script/test/fixtures/buildconfig/docker-compose-build-no-image.yml
./script/test/fixtures/buildconfig/docker-compose-dockerfile.yml
./script/test/fixtures/buildconfig/docker-compose-v3.yml
./script/test/fixtures/buildconfig/docker-compose.yml
./script/test/fixtures/change-in-volume/docker-compose.yml
./script/test/fixtures/compose-env-interpolation/docker-compose.yaml
./script/test/fixtures/compose-file-env-variable/docker-compose.yaml
./script/test/fixtures/configmap-volume/docker-compose-withlabel.yml
./script/test/fixtures/configmap-volume/docker-compose.yml
./script/test/fixtures/configmap/docker-compose.yaml
./script/test/fixtures/controller/docker-compose.yml
./script/test/fixtures/deploy/placement/docker-compose-placement.yaml
./script/test/fixtures/dockerfilepath/docker-compose.yml
./script/test/fixtures/domain/docker-compose-v3.yaml
./script/test/fixtures/domain/docker-compose.yaml
./script/test/fixtures/entrypoint-command/docker-compose.yml
./script/test/fixtures/env-multiple/docker-compose.yml
./script/test/fixtures/env/docker-compose.yml
./script/test/fixtures/envvars-interpolation/docker-compose.yaml
./script/test/fixtures/envvars-separators/docker-compose.yml
./script/test/fixtures/etherpad/docker-compose-no-image.yml
./script/test/fixtures/etherpad/docker-compose-no-ports.yml
./script/test/fixtures/etherpad/docker-compose.yml
./script/test/fixtures/external-traffic-policy/docker-compose-v1.yaml
./script/test/fixtures/external-traffic-policy/docker-compose-v2.yaml
./script/test/fixtures/fsgroup/docker-compose.yaml
./script/test/fixtures/gitlab/docker-compose.yml
./script/test/fixtures/healthcheck/docker-compose-healthcheck.yaml
./script/test/fixtures/host-port-protocol/docker-compose.yaml
./script/test/fixtures/image-pull-secret/compose-files/docker-compose-image-pull-secret.yml
./script/test/fixtures/label-port/docker-compose.yml
./script/test/fixtures/multiple-type-volumes/docker-compose.yaml
./script/test/fixtures/namespace/docker-compose.yaml
./script/test/fixtures/network-policies/docker-compose.yaml
./script/test/fixtures/network/docker-compose-v3.yaml
./script/test/fixtures/nginx-node-redis/docker-compose-v3.yml
./script/test/fixtures/nginx-node-redis/docker-compose.yml
./script/test/fixtures/no-profile-warning/docker-compose.yaml
./script/test/fixtures/ports-with-ip/docker-compose.yml
./script/test/fixtures/pvc-request-size/docker-compose.yml
./script/test/fixtures/read-only/docker-compose.yaml
./script/test/fixtures/redis-example/docker-compose.yml
./script/test/fixtures/resources-lowercase/docker-compose.yaml
./script/test/fixtures/secrets/docker-compose-secrets-long.yml
./script/test/fixtures/secrets/docker-compose-secrets-short.yml
./script/test/fixtures/service-label/docker-compose.yaml
./script/test/fixtures/service-name-change/docker-compose.yml
./script/test/fixtures/single-file-output/docker-compose.yaml
./script/test/fixtures/statefulset/docker-compose.yaml
./script/test/fixtures/stdin-true/docker-compose.yml
./script/test/fixtures/stdin/docker-compose.yaml
./script/test/fixtures/storage-class-name/docker-compose.yml
./script/test/fixtures/tty-true/docker-compose.yml
./script/test/fixtures/unused/expose-service/compose-files/docker-compose-expose-hostname-multiple-ports.yml
./script/test/fixtures/unused/expose-service/compose-files/docker-compose-expose-hostname-tls.yml
./script/test/fixtures/unused/expose-service/compose-files/docker-compose-expose-hostname.yml
./script/test/fixtures/unused/expose-service/compose-files/docker-compose-expose-multiple-hostname-tls.yml
./script/test/fixtures/unused/expose-service/compose-files/docker-compose-expose-multiple-hostname.yml
./script/test/fixtures/unused/expose-service/compose-files/docker-compose-expose-true-multiple-ports.yml
./script/test/fixtures/unused/expose-service/compose-files/docker-compose-expose-true.yml
./script/test/fixtures/unused/v3/docker-compose-3.5.yaml
./script/test/fixtures/unused/v3/docker-compose-deploy.yaml
./script/test/fixtures/unused/v3/docker-compose-env-subs.yaml
./script/test/fixtures/unused/v3/docker-compose-env.yaml
./script/test/fixtures/unused/v3/docker-compose-full-example.yaml
./script/test/fixtures/unused/v3/docker-compose-memcpu-partial.yaml
./script/test/fixtures/unused/v3/docker-compose-memcpu.yaml
./script/test/fixtures/unused/v3/docker-compose-unset-env.yaml
./script/test/fixtures/unused/v3/docker-compose-volumes.yaml
./script/test/fixtures/unused/v3/docker-compose.yaml
./script/test/fixtures/v2/docker-compose.yaml
./script/test/fixtures/v3.0/docker-compose.yaml
./script/test/fixtures/vols-subpath/docker-compose.yaml
./script/test/fixtures/volume-mounts/hostpath/docker-compose-v3.yml
./script/test/fixtures/volume-mounts/hostpath/docker-compose.yml
./script/test/fixtures/volume-mounts/named-volume/docker-compose-v3.yml
./script/test/fixtures/volume-mounts/named-volume/docker-compose.yml
./script/test/fixtures/volume-mounts/simple-vol-mounts/docker-compose.yml
./script/test/fixtures/volume-mounts/tmpfs/docker-compose.yml
./script/test/fixtures/volume-mounts/volumes-from/docker-compose-case.yml
./script/test/fixtures/volume-mounts/volumes-from/docker-compose.yml
./script/test/fixtures/volume-mounts/windows/docker-compose.yaml
./script/test/fixtures/yaml-and-yml/docker-compose.yaml
./script/test/fixtures/yaml-and-yml/yml/docker-compose.yml
./script/test/fixtures/configmap-pod/docker-compose.yml

Why is this needed?

This is needed, because "we're trying to go away from using docker-compose.yml / .yml since compose is an open spec."*

@martinjirku martinjirku added the kind/feature Categorizes issue or PR as related to a new feature. label Jan 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/feature Categorizes issue or PR as related to a new feature.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant