Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] Missing imagePullSecret when converting to Helm with many containers in one Pod #1645

Closed
bl-sarus opened this issue May 22, 2023 · 2 comments · Fixed by #1666
Closed
Assignees
Labels
kind/bug Categorizes issue or PR as related to a bug.

Comments

@bl-sarus
Copy link

Expected Behavior

When I use the CLI argument --service-group-mode=label, I expect the imagePullSecret property to be added to the generated files chart/templates/*-deployment.yaml or chart/templates/*-statefulset.yaml:

      imagePullSecrets:
        - name: mysecret

Actual Behavior

It is missing, resulting in errors when the Helm install requires pulling images from a private registry.

Steps To Reproduce

Using the attached docker-compose, I get the following outcomes:

  • kompose convert --service-group-mode=label -c -f docker-compose.yaml: missing parameter
  • kompose convert --service-group-mode=label --controller statefulset -c -f docker-compose.yaml: missing parameter
  • kompose convert -c -f docker-compose.yaml: imagePullSecrets is present in deploy files
  • kompose convert --controller statefulset -c -f docker-compose.yaml: imagePullSecrets is present in statefulset files

Kompose Version

1.28.0 (c4137012e)

Docker-Compose file

version: '3'
services:
  container-1:
    image: busybox
    command:
      - sh
      - -c
      - 'while true; echo "container-1 running"; sleep 10; done'
    labels:
      kompose.image-pull-secret: mysecret
      kompose.service.group: mygroup
  container-2:
    image: busybox
    command:
      - sh
      - -c
      - 'while true; echo "container-2 running"; sleep 10; done'
    labels:
      kompose.image-pull-secret: mysecret
      kompose.service.group: mygroup


### Anything else?

_No response_
@bl-sarus bl-sarus added the kind/bug Categorizes issue or PR as related to a bug. label May 22, 2023
@bl-sarus bl-sarus changed the title [BUG] Missing imagePullSecret when to Helm with many containers in one Pod [BUG] Missing imagePullSecret when converting to Helm with many containers in one Pod May 22, 2023
@AhmedGrati
Copy link
Contributor

/assign

@AhmedGrati
Copy link
Contributor

@bl-sarus feel free to review the PR if you have time so we can merge it ASAP.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/bug Categorizes issue or PR as related to a bug.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants