Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

audit: ensure no etags for dumped resources #2062

Closed
spiffxp opened this issue May 19, 2021 · 3 comments · Fixed by #2089
Closed

audit: ensure no etags for dumped resources #2062

spiffxp opened this issue May 19, 2021 · 3 comments · Fixed by #2089
Assignees
@spiffxp
Labels
area/audit Audit of project resources, audit followup issues, code in audit/ kind/bug Categorizes issue or PR as related to a bug. priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release.
Milestone
v1.22

Comments

@spiffxp
Copy link
Member

spiffxp commented May 19, 2021

I noticed we started picking up etags for secret descriptions in #2011

Go through audit/audit-gcp.sh

Either add etag deletion to things that don't have it yet, or try refactoring so that everything goes through one (jq, yq, whatever) filter

/kind bug
/priority important-soon
because ever-changing etags makes for noisy audit PRs
/wg k8s-infra
/area infra/auditing
@k8s-ci-robot k8s-ci-robot added kind/bug Categorizes issue or PR as related to a bug. priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. wg/k8s-infra area/audit Audit of project resources, audit followup issues, code in audit/ labels May 19, 2021
@spiffxp
Copy link
Member Author

spiffxp commented May 19, 2021

/milestone v1.22

@k8s-ci-robot k8s-ci-robot added this to the v1.22 milestone May 19, 2021
This was referenced May 19, 2021
Merged
Open
Merged
Closed
Merged
@spiffxp
Copy link
Member Author

spiffxp commented May 24, 2021

#2089 should fix this

@spiffxp
Copy link
Member Author

spiffxp commented May 24, 2021

/assign

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@spiffxp spiffxp

Labels
area/audit Audit of project resources, audit followup issues, code in audit/ kind/bug Categorizes issue or PR as related to a bug. priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release.
Projects
None yet
Milestone
v1.22
Development

Successfully merging a pull request may close this issue.

audit: strip etags from json output, fix bq access dump spiffxp/k8s.io
2 participants
@spiffxp @k8s-ci-robot