Skip to content
This repository has been archived by the owner on Sep 24, 2021. It is now read-only.

Support portmapping #162

Merged
merged 3 commits into from
Jun 9, 2017

Conversation

heartlock
Copy link
Contributor

@heartlock heartlock commented Jun 5, 2017

What this PR does:

  • support port mapping
  • enable e2e test for port mapping
  • update README

@feiskyer Thanks for your help! Ready for review.
Closes: #122

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Jun 5, 2017
@k8s-reviewable
Copy link

This change is Reviewable

@heartlock heartlock force-pushed the support-portmapping branch from fbce34e to f0aab8c Compare June 7, 2017 08:45
Signed-off-by: heartlock <21521209@zju.edu.cn>
@heartlock heartlock force-pushed the support-portmapping branch from f0aab8c to 12875ef Compare June 8, 2017 06:20
HostPort int32 `json:"hostPort"`
ContainerPort int32 `json:"containerPort"`
Protocol string `json:"protocol"`
HostIP string `json:"hostIP"`
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

hostIP,omitempty

hack/test-e2e.sh Outdated
{
"type": "portmap",
"capabilities": {"portMappings": true},
"snat": false
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@@ -88,32 +88,44 @@ function install_remote_hyperd() {
function configure_cni() {
# install cni
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

could you also update the CNI setup in README.md?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

will do

Signed-off-by: heartlock <21521209@zju.edu.cn>
@heartlock heartlock force-pushed the support-portmapping branch from 12875ef to 3cc4b06 Compare June 8, 2017 09:42
Signed-off-by: heartlock <21521209@zju.edu.cn>
@heartlock heartlock changed the title [WIP]Support portmapping Support portmapping Jun 8, 2017
@feiskyer feiskyer self-assigned this Jun 9, 2017
@feiskyer
Copy link
Contributor

feiskyer commented Jun 9, 2017

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Jun 9, 2017
@feiskyer feiskyer merged commit c8eacdb into kubernetes-retired:master Jun 9, 2017
@feiskyer feiskyer mentioned this pull request Jun 28, 2017
3 tasks
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants