Skip to content
This repository has been archived by the owner on Sep 24, 2021. It is now read-only.

Filter CodeExitError type error in Exec streaming API #145

Merged
merged 1 commit into from
May 17, 2017
Merged

Filter CodeExitError type error in Exec streaming API #145

merged 1 commit into from
May 17, 2017

Conversation

Crazykev
Copy link
Contributor

close #134

# crictl info
Version:  0.1.0
RuntimeName:  hyper
RuntimeVersion:  0.8.1
RuntimeApiVersion:  0.1.0
# crictl exec -i -t 65c58ed5a447e67f887d9ac285a8f239670bce9ef8cd4f6655e8fdc7ba113845 sh
/ # ls
ls
bin   dev   etc   home  lib   proc  root  sys   tmp   usr   var
/ # exit
exit

/cc @feiskyer

Signed-off-by: Crazykev crazykev@zju.edu.cn

@Crazykev
filter CodeExitError type error in Exec streaming API
9df01d3 
Signed-off-by: Crazykev <crazykev@zju.edu.cn>
@k8s-ci-robot k8s-ci-robot requested a review from feiskyer May 17, 2017 10:44
@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label May 17, 2017
@k8s-reviewable
Copy link

This change is Reviewable

@Crazykev Crazykev mentioned this pull request May 17, 2017
Closed
@feiskyer
Copy link
Contributor

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm Indicates that a PR is ready to be merged. label May 17, 2017
@feiskyer feiskyer merged commit 1db297b into kubernetes-retired:master May 17, 2017
@Crazykev Crazykev deleted the fix-exec branch May 17, 2017 12:11
This was referenced Jun 28, 2017
Closed
Closed
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@feiskyer feiskyer feiskyer approved these changes

Assignees

@feiskyer feiskyer

Labels
cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Exec command failed via crictl
4 participants
@Crazykev @k8s-reviewable @feiskyer @k8s-ci-robot