Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

2727 - promote grpc probes to GA #3807

Merged
merged 4 commits into from
Feb 7, 2023
Merged

2727 - promote grpc probes to GA #3807

merged 4 commits into from
Feb 7, 2023

Conversation

SergeyKanzhelev
Copy link
Member

/sig node
/sig network

The feature is ready for wide adoption

@k8s-ci-robot k8s-ci-robot added sig/node Categorizes an issue or PR as relevant to SIG Node. sig/network Categorizes an issue or PR as relevant to SIG Network. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/kep Categorizes KEP tracking issues and PRs modifying the KEP directory labels Feb 1, 2023
@k8s-ci-robot k8s-ci-robot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Feb 1, 2023
@SergeyKanzhelev
Copy link
Member Author

/cc @thockin @bowei @PxyUp

@johnbelamaric would you be my PRR approver for this?

@k8s-ci-robot
Copy link
Contributor

@SergeyKanzhelev: GitHub didn't allow me to request PR reviews from the following users: PxyUp.

Note that only kubernetes members and repo collaborators can review this PR, and authors cannot review their own PRs.

In response to this:

/cc @thockin @bowei @PxyUp

@johnbelamaric would you be my PRR approver for this?

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@thockin
Copy link
Member

thockin commented Feb 1, 2023

/approve

@bowei - I am giving you the LGTM since you are closer to it than me.

@bowei
Copy link
Member

bowei commented Feb 1, 2023

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Feb 1, 2023
@dchen1107
Copy link
Member

/approve

@SergeyKanzhelev
Copy link
Member Author

/assign @johnbelamaric

@johnbelamaric would you be ok to do PRR review for this? Good think we passed the skew problems as the beta was released in 1.24. Which makes PRR review very straightforward

@marosset marosset changed the title promote grpc probes to GA 2727 - promote grpc probes to GA Feb 3, 2023
@marosset marosset mentioned this pull request Feb 3, 2023
Closed
12 tasks
@marosset
Copy link
Contributor

marosset commented Feb 3, 2023

Please update the README.md to include updates to the Test Plan in the KEP template that were added in v1.25.

Having this section filled out is a requirement for including the enhancement into the release.
Thanks!

@SergeyKanzhelev @marosset
Update keps/sig-node/2727-grpc-probe/kep.yaml
e2ff312 
Co-authored-by: Mark Rossetti <marosset@microsoft.com>
@k8s-ci-robot k8s-ci-robot removed the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Feb 7, 2023
jeremyrickard
jeremyrickard reviewed Feb 7, 2023
View reviewed changes
Copy link
Contributor

@jeremyrickard jeremyrickard left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @SergeyKanzhelev, this needs an update to the PRR. There is a new question in the PRR questionnaire (78200cb) that needs to be added to this, and probably double check the other fields.

@k8s-ci-robot k8s-ci-robot removed the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Feb 7, 2023
@k8s-ci-robot k8s-ci-robot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Feb 7, 2023
@SergeyKanzhelev
Copy link
Member Author

Hey @SergeyKanzhelev, this needs an update to the PRR. There is a new question in the PRR questionnaire (78200cb) that needs to be added to this, and probably double check the other fields.

Updated to the latest template. This is ready for review

thockin
thockin reviewed Feb 7, 2023
View reviewed changes
Copy link
Member

@thockin thockin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One small suggestion in drawbacks.

/approve from sig-net

keps/sig-node/2727-grpc-probe/README.md Outdated Show resolved Hide resolved
@thockin thockin added the tide/merge-method-squash Denotes a PR that should be squashed by tide when it merges. label Feb 7, 2023
@johnbelamaric
Copy link
Member

/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dchen1107, johnbelamaric, SergeyKanzhelev, thockin

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Feb 7, 2023
@thockin
Copy link
Member

thockin commented Feb 7, 2023

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Feb 7, 2023
@k8s-ci-robot k8s-ci-robot merged commit 1cf0b07 into kubernetes:master Feb 7, 2023
@k8s-ci-robot k8s-ci-robot added this to the v1.27 milestone Feb 7, 2023
@SergeyKanzhelev SergeyKanzhelev deleted the grpcToGA branch February 7, 2023 19:33
SergeyKanzhelev added a commit to SergeyKanzhelev/enhancements that referenced this pull request Feb 9, 2023
@SergeyKanzhelev @marosset
2727 - promote grpc probes to GA (kubernetes#3807)
053c87a 
* promote grpc probes to GA

* Update keps/sig-node/2727-grpc-probe/kep.yaml

Co-authored-by: Mark Rossetti <marosset@microsoft.com>

* updated to the latest template

* Filled up Drawbacks

---------

Co-authored-by: Mark Rossetti <marosset@microsoft.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@thockin thockin thockin left review comments

@marosset marosset marosset left review comments

@jeremyrickard jeremyrickard jeremyrickard left review comments

@dchen1107 dchen1107 Awaiting requested review from dchen1107

@derekwaynecarr derekwaynecarr Awaiting requested review from derekwaynecarr

@bowei bowei Awaiting requested review from bowei

Assignees

@bowei bowei

@thockin thockin

@johnbelamaric johnbelamaric

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/kep Categorizes KEP tracking issues and PRs modifying the KEP directory lgtm "Looks good to me", indicates that a PR is ready to be merged. sig/network Categorizes an issue or PR as relevant to SIG Network. sig/node Categorizes an issue or PR as relevant to SIG Node. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. tide/merge-method-squash Denotes a PR that should be squashed by tide when it merges.
Projects
SIG Node PR Triage
Archived in project
Milestone
v1.27
Development

Successfully merging this pull request may close these issues.
8 participants
@SergeyKanzhelev @k8s-ci-robot @thockin @bowei @dchen1107 @marosset @johnbelamaric @jeremyrickard