From 0cc9ad5ea75d410fc5e0eb8302851d6c9e0ae753 Mon Sep 17 00:00:00 2001 From: Patrick Ohly Date: Mon, 2 Dec 2024 14:43:58 +0100 Subject: [PATCH] remove import doc comments The "// import " comment has been superseded by Go modules. We don't have to remove them, but doing so has some advantages: - They are used inconsistently, which is confusing. - We can then also remove the (currently broken) hack/update-vanity-imports.sh. - Last but not least, it would be a first step towards avoiding the k8s.io domain. This commit was generated with sed -i -e 's;^package \(.*\) // import.*;package \1;' $(git grep -l '^package.*// import' | grep -v 'vendor/') Everything was included, except for package labels // import k8s.io/kubernetes/pkg/util/labels because that package is marked as "read-only". Kubernetes-commit: 8a908e0c0bd96a3455edf7e3b5f5af90564e65b0 --- doc.go | 2 +- pkg/errors/doc.go | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/doc.go b/doc.go index c74e04a..0a925ff 100644 --- a/doc.go +++ b/doc.go @@ -14,4 +14,4 @@ See the License for the specific language governing permissions and limitations under the License. */ -package criapi // import "k8s.io/cri-api" +package criapi diff --git a/pkg/errors/doc.go b/pkg/errors/doc.go index f3413ee..c7a7bec 100644 --- a/pkg/errors/doc.go +++ b/pkg/errors/doc.go @@ -16,4 +16,4 @@ limitations under the License. // Package errors provides helper functions for use by the kubelet // to deal with CRI errors. -package errors // import "k8s.io/cri-api/pkg/errors" +package errors