Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ProviderID Prefix to vsphere-paravirtual which doesn't match CAPV providerID Prefix #447

Closed
lubronzhan opened this issue Mar 13, 2021 · 1 comment
Labels
kind/bug Categorizes issue or PR as related to a bug.

Comments

@lubronzhan
Copy link
Contributor

lubronzhan commented Mar 13, 2021

Is this a BUG REPORT or FEATURE REQUEST?:

Uncomment only one, leave it on its own line:

/kind bug
/kind feature

/kind bug
What happened:
When deployed with CAPV using the vsphere-paravirtual CP, providerID in machine spec is like providerID: vsphere://421fddb7-1f54-b972-1b97-528b55613b94, but on the node spec vsphere-paravirtual://421cae04-e91b-f502-03a4-e9b4e4690115, which set by the paravirtual provider.

Because ProviderID is constructed using the ProviderName
https://github.com/kubernetes/cloud-provider/blob/2c911671bd3eeff09ec2e093a5544ed56dd7f06f/cloud.go#L114

Then control plane and worker nodes will be stuck creating, because machine_controller can't find corresponding k8s node by using the providerID

What you expected to happen:
Either CAPI side set providerID prefix to vsphere-paravirtual as well, or we change the providerID in paravirtual to vsphere as well
How to reproduce it (as minimally and precisely as possible):
Deploy TKGs with this vsphere-paravirtual cloud-provider

Environment:

  • vsphere-cloud-controller-manager version: dev build from master
  • OS (e.g. from /etc/os-release):
NAME="VMware Photon OS"
VERSION="3.0"
ID=photon
VERSION_ID=3.0
PRETTY_NAME="VMware Photon OS/Linux"
ANSI_COLOR="1;34"
HOME_URL="https://vmware.github.io/photon/"
BUG_REPORT_URL="https://github.com/vmware/photon/issues"
  • Kernel (e.g. uname -a): Linux 421cf7cfe1f42f446eb75e2a4ebbd34e 4.19.164-3.ph3-esx Create a SECURITY_CONTACTS file. #1-photon SMP Wed Jan 20 02:17:01 UTC 2021 x86_64 GNU/Linux
  • Install tools:
  • Others:
@k8s-ci-robot k8s-ci-robot added the kind/bug Categorizes issue or PR as related to a bug. label Mar 13, 2021
@lubronzhan lubronzhan changed the title ProviderID Prefix to vsphere-paravirtual which doesn't match CAPW providerID Prefix ProviderID Prefix to vsphere-paravirtual which doesn't match CAPV providerID Prefix Mar 17, 2021
@lubronzhan
Copy link
Contributor Author

Fixed in #448

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/bug Categorizes issue or PR as related to a bug.
Projects
None yet
Development

No branches or pull requests

2 participants