Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cluster Autoscaler: unit tests not passing on 1.19 and 1.20 #4368

Closed
towca opened this issue Sep 30, 2021 · 2 comments
Closed

Cluster Autoscaler: unit tests not passing on 1.19 and 1.20 #4368

towca opened this issue Sep 30, 2021 · 2 comments
Labels
area/cluster-autoscaler area/provider/azure Issues or PRs related to azure provider kind/bug Categorizes issue or PR as related to a bug.

Comments

@towca
Copy link
Collaborator

towca commented Sep 30, 2021

The recent Azure cherry-picks to 1.19 and 1.20 (#4356, #4355) broke the Cluster Autoscaler build. It wasn't caught by CI because Github Actions hadn't been backported to 1.19 and 1.20. I tried fixing it, and there are 2 issues:

Github Actions are now running on 1.20 and 1.19.

Please fix ASAP.

@feiskyer @marwanad @nilo19

@towca towca added area/cluster-autoscaler area/provider/azure Issues or PRs related to azure provider kind/bug Categorizes issue or PR as related to a bug. labels Sep 30, 2021
@marwanad
Copy link
Member

marwanad commented Oct 1, 2021

Fixed in #4371 and #4370.

Sorry about that!

@towca
Copy link
Collaborator Author

towca commented Oct 1, 2021

Np, thanks for the quick fix!

@towca towca closed this as completed Oct 1, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/cluster-autoscaler area/provider/azure Issues or PRs related to azure provider kind/bug Categorizes issue or PR as related to a bug.
Projects
None yet
Development

No branches or pull requests

2 participants