Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

yaml formatting & indentation #26

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

yaml formatting & indentation #26

wants to merge 1 commit into from

Conversation

jmnote
Copy link

@jmnote jmnote commented Nov 19, 2024

yaml formatting & indentation

@jmnote
yaml-indentation
26f8533 
Signed-off-by: Jmnote <opcore@gmail.com>
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: jmnote
Once this PR has been reviewed and has the lgtm label, please assign pmorie for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Nov 19, 2024
@k8s-ci-robot
Copy link
Contributor

Welcome @jmnote!

It looks like this is your first PR to kubernetes-sigs/sig-multicluster-site 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.

You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.

You can also check if kubernetes-sigs/sig-multicluster-site has its own contribution guidelines.

You may want to refer to our testing guide if you run into trouble with your tests not passing.

If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!

Thank you, and welcome to Kubernetes. 😃

@k8s-ci-robot k8s-ci-robot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Nov 19, 2024
@netlify Netlify
Copy link

netlify bot commented Nov 19, 2024 •
edited
Loading

✅ Deploy Preview for kubernetes-sig-multicluster ready!

Name Link
🔨 Latest commit 26f8533
🔍 Latest deploy log https://app.netlify.com/sites/kubernetes-sig-multicluster/deploys/673c5117a609420008ce5ba5
😎 Deploy Preview https://deploy-preview-26--kubernetes-sig-multicluster.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

olivercodes
olivercodes reviewed Dec 13, 2024
View reviewed changes
site-src/concepts/cluster-profile-api.md
lastTransitionTime: "2023-05-08T07:58:55Z"
message: ""
version:
kubernetes: 1.28.0
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

minor, but maybe we could reflect a more recent version of k8s in this example?

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In this PR, wouldn't it be better to focus on YAML formatting and indentation? It would be better to create a separate issue for version-related matters.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fair enough, yup

@olivercodes
Copy link
Member

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Dec 17, 2024
@olivercodes olivercodes removed their assignment Dec 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@olivercodes olivercodes olivercodes left review comments

@JeremyOT JeremyOT Awaiting requested review from JeremyOT

@lauralorenz lauralorenz Awaiting requested review from lauralorenz

Assignees
No one assigned
Labels
cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

YAML Indentation
3 participants
@jmnote @k8s-ci-robot @olivercodes