diff --git a/pkg/resourceprovider/provider.go b/pkg/resourceprovider/provider.go index 7d47af6b1..b1dc0151d 100644 --- a/pkg/resourceprovider/provider.go +++ b/pkg/resourceprovider/provider.go @@ -118,9 +118,10 @@ type nsQueryResults struct { err error } +// GetContainerMetrics implements the provider.MetricsProvider interface. It may return nil, nil, nil. func (p *resourceProvider) GetContainerMetrics(pods ...apitypes.NamespacedName) ([]provider.TimeInfo, [][]metrics.ContainerMetrics, error) { if len(pods) == 0 { - return nil, nil, fmt.Errorf("no pods to fetch metrics for") + return nil, nil, nil } // TODO(directxman12): figure out how well this scales if we go to list 1000+ pods @@ -238,9 +239,10 @@ func (p *resourceProvider) assignForPod(pod apitypes.NamespacedName, resultsByNs *resMetrics = containerMetricsList } +// GetNodeMetrics implements the provider.MetricsProvider interface. It may return nil, nil, nil. func (p *resourceProvider) GetNodeMetrics(nodes ...string) ([]provider.TimeInfo, []corev1.ResourceList, error) { if len(nodes) == 0 { - return nil, nil, fmt.Errorf("no nodes to fetch metrics for") + return nil, nil, nil } now := pmodel.Now()