Inline yaml comments not preserved in v1.0.6

[ahmetb]

Apparently #233 added support for preserving comments.

However with v1.0.6 (017c4ae) I'm not seeing this behavior.

kustomization.yaml:

resources:
- service.yaml

base.yaml:

apiVersion: v1
kind: Service
metadata:
  name: "<name-here>"
  labels:
    app: "<label>"
spec:
  selector:
    app: "<pod-label>"
  ports:
  - protocol: TCP
    port: 80         # port number the Service load balancer will accept traffic
    targetPort: 5000 # port number defined on Pod's containerPort

patch/patch.yaml:

apiVersion: v1
kind: Service
metadata:
  name: "<name-here>"
spec:
  loadBalancerIP: "TYPE.IP.ADDR.HERE" # static IP address reserved for this LB

patch/kustomization.yaml

bases:
- "../"
patches:
- patch.yaml

kustomize build patch/ output (has no comments):

apiVersion: v1
kind: Service
metadata:
  labels:
    app: <label>
  name: <name-here>
spec:
  kind: LoadBalancer
  loadBalancerIP: TYPE.IP.ADDR.HERE
  ports:
  - port: 80
    protocol: TCP
    targetPort: 5000
  selector:
    app: <pod-label>

[Liujingfang1]

@ahmetb I think you misunderstood the scope of that PR. In v1.0.6, preserving comments(not including the inline comment) and order is only for kustomization.yaml and it happens during kustomize edit. We'd also like Kustomize to preserve arbitrary comments, but couldn't support that at this moment. To do that, we need a yaml library being able to preserve all comments. So far we haven't found such library available.

[ahmetb]

I see my bad. Feel free to close.