Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Extend the unit-test coverage for jobframework, #922

Closed
Tracked by #974
trasc opened this issue Jun 29, 2023 · 4 comments · Fixed by #979
Closed
Tracked by #974

Extend the unit-test coverage for jobframework, #922

trasc opened this issue Jun 29, 2023 · 4 comments · Fixed by #979
Assignees
@stuton
Labels
kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt.

Comments

@trasc
Copy link
Contributor

trasc commented Jun 29, 2023

What would you like to be cleaned:
Extend the unit-test coverage for jobframework,
ref: https://github.com/kubernetes-sigs/kueue/pull/762/files#r1245444318
Why is this needed:
@trasc trasc added the kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. label Jun 29, 2023
@trasc trasc mentioned this issue Jun 29, 2023
Merged
@stuton
Copy link
Contributor

stuton commented Jun 29, 2023

/assign

@alculquicondor
Copy link
Contributor

There are two alternatives:

  • Create a FakeJob implementation to test the jobframework package itself.
  • Test each of the job packages (job, mpijob, jobset) using a fake client and the reconciler code.

I have a preference for the second.

@trasc
Copy link
Contributor Author

trasc commented Jun 30, 2023

There are two alternatives:

  • Create a FakeJob implementation to test the jobframework package itself.
  • Test each of the job packages (job, mpijob, jobset) using a fake client and the reconciler code.

I have a preference for the second.

going with the second one we will have a lot of duplicate tests.

@alculquicondor
Copy link
Contributor

It's not really duplicate, as some jobs might behave differently and implement optional extensions.

This was referenced Jul 6, 2023
Merged
Closed
@achernevskii achernevskii mentioned this issue Jul 12, 2023
Merged
@stuton stuton mentioned this issue Jul 12, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@stuton stuton

Labels
kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Extend unit-test coverage for jobframework epam/kubernetes-kueue
3 participants
@alculquicondor @stuton @trasc