Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Delay preemptions for two-phase admission #3758

Open
3 tasks
mimowo opened this issue Dec 6, 2024 · 4 comments
Open
3 tasks

Delay preemptions for two-phase admission #3758

mimowo opened this issue Dec 6, 2024 · 4 comments
Labels
kind/feature Categorizes issue or PR as related to a new feature.

Comments

@mimowo
Copy link
Contributor

mimowo commented Dec 6, 2024

What would you like to be added:

An ability to delay preemptions in case of 2-phase admission.

Why is this needed:

Currently preemptions happen when reserving the quota, before additional admission checks. However, some admission checks may take a long time, and maybe over this time the workloads would complete on their own.

Completion requirements:

This enhancement requires the following artifacts:

  • Design doc
  • API change
  • Docs update

The artifacts should be linked in subsequent comments.

@mimowo mimowo added the kind/feature Categorizes issue or PR as related to a new feature. label Dec 6, 2024
@mimowo
Copy link
Contributor Author

mimowo commented Dec 6, 2024

cc @mwielgus @mwysokin @tenzen-y

@mimowo mimowo changed the title Delay preemptions for 2-phase admission Delay preemptions for two-phase admission Dec 6, 2024
@Horiodino
Copy link
Contributor

/assign
Hi @mimowo, could you please provide more context about this? I'm not very familiar with the codebase.

@mimowo
Copy link
Contributor Author

mimowo commented Jan 21, 2025

Hi @Horiodino, it is nice to see you are looking for contributions to the project, however, it is hard to indicate a specific place in code at this point. This is actually a complex task and will require some design as a KEP and very likely some API changes to control the behavior. So, I would not recommend it as a "warm up" task.

@Horiodino
Copy link
Contributor

/unassign

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/feature Categorizes issue or PR as related to a new feature.
Projects
None yet
Development

No branches or pull requests

2 participants