Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ingress-nginx] missing resources (ingressClass, services, maybe more) #9936

Closed
peschmae opened this issue Mar 28, 2023 · 4 comments · Fixed by #10091
Closed

[ingress-nginx] missing resources (ingressClass, services, maybe more) #9936

peschmae opened this issue Mar 28, 2023 · 4 comments · Fixed by #10091
Assignees
Labels
kind/bug Categorizes issue or PR as related to a bug. kind/feature Categorizes issue or PR as related to a new feature.

Comments

@peschmae
Copy link
Contributor

peschmae commented Mar 28, 2023

After deploying a new cluster with kubespray and ingress-nginx enabled, there is no IngressClass resource created.
The IngressClass resource was introduced in 1.18, and the annotation kubernetes.io/ingress.class is deprecated these days.
It seems a while back the ingress-nginx version in kubespray was updated, but the new resources introduced weren't copied over.

Additionally there are also multiple services that would normally be created if one uses the official deployment files: e.g.
https://raw.githubusercontent.com/kubernetes/ingress-nginx/main/deploy/static/provider/baremetal/deploy.yaml or https://raw.githubusercontent.com/kubernetes/ingress-nginx/main/deploy/static/provider/cloud/deploy.yaml

I think adding at least the IngressClass would be useful, adding the services will be more work and require some changes to the deployment which will make it harder to ensure not to brake existing clusters.

Maybe instead of introducing the services, it would be an option to provide a way to deploy ingress-nginx through the helm-apps role, and just add the IngressClass to the existing role to move away from the deprecated annotation.

Environment:

  • Cloud provider or hardware configuration:
    Proxmox / Baremetal
  • OS (printf "$(uname -srm)\n$(cat /etc/os-release)\n"):
    Ansible node: Linux 5.10.0-21-amd64 x86_64 / PRETTY_NAME="Debian GNU/Linux 11 (bullseye)"
    Kubernetes Master & Workers: Linux 6.1.0-6-amd64 x86_64 PRETTY_NAME="Debian GNU/Linux 12 (bookworm)"

Kubespray version (commit) (git rev-parse --short HEAD): 3450865

Network plugin used: Cilium

Command used to invoke ansible:
ansible-playbook -i inventory/mycluster/hosts.yml cluster.yml -b -v

Output of ansible run:
Success

@peschmae peschmae added the kind/bug Categorizes issue or PR as related to a bug. label Mar 28, 2023
@kundan2707
Copy link
Contributor

/assign

@kundan2707
Copy link
Contributor

/kind feature

@k8s-ci-robot k8s-ci-robot added the kind/feature Categorizes issue or PR as related to a new feature. label Mar 31, 2023
@peschmae
Copy link
Contributor Author

Hi @kundan2707
Are you intending to work on this for #10075 ?
Otherwise I'll make a pull reuqest adding the ingressClass resource, to solve #10014 and make the nginx ignress more future proof

@kundan2707
Copy link
Contributor

@peschmae Please go ahead and make a pull request

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/bug Categorizes issue or PR as related to a bug. kind/feature Categorizes issue or PR as related to a new feature.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants