Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

NodeLocal DNS pod label #9717

Closed
stelucz opened this issue Jan 27, 2023 · 2 comments · Fixed by #9745
Closed

NodeLocal DNS pod label #9717

stelucz opened this issue Jan 27, 2023 · 2 comments · Fixed by #9745
Labels
kind/feature Categorizes issue or PR as related to a new feature.

Comments

@stelucz
Copy link
Contributor

stelucz commented Jan 27, 2023

Not a really bug but labeling of NodeLocal DNS pods is not matching the upstream DaemonSet definition.

What would you like to be added:
Replace label k8s-app: nodelocaldns in DaemonSet template by k8s-app: node-local-dns.

Why is this needed:
Label in template should match upstream DaemonSet definition as other projects/deployments can rely on it. For example Cilium connectivity test is using expected "correct" label k8s-app: node-local-dns in NetworkPolicies but they do not work as cluster has pods labeled as k8s-app: nodelocaldns.

What do you think?
@stelucz stelucz added the kind/feature Categorizes issue or PR as related to a new feature. label Jan 27, 2023
@yankay
Copy link
Member

yankay commented Jan 31, 2023

Thanks @stelucz
Would you please provide a PR.

@cyclinder
Copy link
Contributor

Nice catch! @stelucz

Could you mind opening a PR for this?

@stelucz stelucz mentioned this issue Feb 1, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
kind/feature Categorizes issue or PR as related to a new feature.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Replace nodelocaldns label stelucz/kubespray
3 participants
@yankay @stelucz @cyclinder