Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add optional arguments for external cloud controller manager DaemonSet #6780

Closed
JorenZ opened this issue Oct 2, 2020 · 0 comments · Fixed by #6783
Closed

Add optional arguments for external cloud controller manager DaemonSet #6780

JorenZ opened this issue Oct 2, 2020 · 0 comments · Fixed by #6783
Labels
kind/feature Categorizes issue or PR as related to a new feature.

Comments

@JorenZ
Copy link
Contributor

JorenZ commented Oct 2, 2020

What would you like to be added:
The option to add arguments to the external cloud controller manager DaemonSet.

Why is this needed:
In our case, we wanted to harden our TLS setup so we wanted to add --tls-min-version=VersionTLS13.

At any rate, the cloud controller manager has many more command line options than are currently hardcoded in the DaemonSet templates in kubespray/roles/kubernetes-apps/external_cloud_controller/openstack/ and kubespray/roles/kubernetes-apps/external_cloud_controller/vsphere.

The current arguments are

            - --v=1
            - --cloud-config=$(CLOUD_CONFIG)
            - --cloud-provider=openstack
            - --use-service-account-credentials=true
            - --address=127.0.0.1

(openstack) and

            - --v=2
            - --cloud-provider=vsphere
            - --cloud-config=/etc/cloud/vsphere.conf

(vsphere), respectively.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/feature Categorizes issue or PR as related to a new feature.
Projects
None yet
1 participant