Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ownership /usr/local/bin changed to kube by Kubespray #5519

Closed
basvandenbrink opened this issue Jan 8, 2020 · 13 comments
Closed

Ownership /usr/local/bin changed to kube by Kubespray #5519

basvandenbrink opened this issue Jan 8, 2020 · 13 comments
Labels
kind/bug Categorizes issue or PR as related to a bug. lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale.

Comments

@basvandenbrink
Copy link
Contributor

Kubespray changes the owner of /usr/local/bin to the kube user. With Red Hat, this directory is created by the filesystem package. The permissions should not be modified by any application, since it is a core directory of the OS. This also causes verification errors when verifying RPM packages.

The owner is modified by Kubespray here: https://github.com/kubernetes-sigs/kubespray/blob/v2.11.0/roles/kubernetes/preinstall/tasks/0050-create_directories.yml#L20.

Environment:

  • Cloud provider or hardware configuration: bare metal

  • OS (printf "$(uname -srm)\n$(cat /etc/os-release)\n"):

Linux 3.10.0-1062.el7.x86_64 x86_64
NAME="Red Hat Enterprise Linux Server"
VERSION="7.7 (Maipo)"
ID="rhel"
ID_LIKE="fedora"
VARIANT="Server"
VARIANT_ID="server"
VERSION_ID="7.7"
PRETTY_NAME="Red Hat Enterprise Linux Server 7.7 (Maipo)"
ANSI_COLOR="0;31"
CPE_NAME="cpe:/o:redhat:enterprise_linux:7.7:GA:server"
HOME_URL="https://www.redhat.com/"
BUG_REPORT_URL="https://bugzilla.redhat.com/"

REDHAT_BUGZILLA_PRODUCT="Red Hat Enterprise Linux 7"
REDHAT_BUGZILLA_PRODUCT_VERSION=7.7
REDHAT_SUPPORT_PRODUCT="Red Hat Enterprise Linux"
REDHAT_SUPPORT_PRODUCT_VERSION="7.7"
  • Version of Ansible (ansible --version): ansible 2.7.12

Kubespray version (commit) (git rev-parse --short HEAD): 86cc703 (v2.11.0)

Network plugin used: Calico

@basvandenbrink basvandenbrink added the kind/bug Categorizes issue or PR as related to a bug. label Jan 8, 2020
@basvandenbrink basvandenbrink changed the title Ownership /usr/local/bin changed to kube Ownership /usr/local/bin changed to kube by Kubespray Jan 8, 2020
@jseguillon
Copy link
Contributor

Indeed, this line is here to create the directory with kube user as owner if the directory does not exists. Testing if the directory exists before creating it may be a good idea, to avoid owner being changed.

Would you have time to test and provide a pull request ?

@basvandenbrink
Copy link
Contributor Author

I would love to provide a pull request, but I have to wait until the company gives us permission to sign the CNCF CLA, unfortunately. I cannot give an indication when this will happen.

@fejta-bot
Copy link

Issues go stale after 90d of inactivity.
Mark the issue as fresh with /remove-lifecycle stale.
Stale issues rot after an additional 30d of inactivity and eventually close.

If this issue is safe to close now please do so with /close.

Send feedback to sig-testing, kubernetes/test-infra and/or fejta.
/lifecycle stale

@k8s-ci-robot k8s-ci-robot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Apr 8, 2020
@basvandenbrink
Copy link
Contributor Author

/remove-lifecycle stale

@k8s-ci-robot k8s-ci-robot removed the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Apr 9, 2020
@floryut
Copy link
Member

floryut commented Jun 15, 2020

I would love to provide a pull request, but I have to wait until the company gives us permission to sign the CNCF CLA, unfortunately. I cannot give an indication when this will happen.

If you can't sign cla, don't hesitate to propose a patch and we'll pr this for you 👍

@fejta-bot
Copy link

Issues go stale after 90d of inactivity.
Mark the issue as fresh with /remove-lifecycle stale.
Stale issues rot after an additional 30d of inactivity and eventually close.

If this issue is safe to close now please do so with /close.

Send feedback to sig-testing, kubernetes/test-infra and/or fejta.
/lifecycle stale

@k8s-ci-robot k8s-ci-robot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Sep 13, 2020
@mpepping
Copy link

/remove-lifecycle stale

@k8s-ci-robot k8s-ci-robot removed the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Sep 16, 2020
@fejta-bot
Copy link

Issues go stale after 90d of inactivity.
Mark the issue as fresh with /remove-lifecycle stale.
Stale issues rot after an additional 30d of inactivity and eventually close.

If this issue is safe to close now please do so with /close.

Send feedback to sig-testing, kubernetes/test-infra and/or fejta.
/lifecycle stale

@k8s-ci-robot k8s-ci-robot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Dec 15, 2020
@basvandenbrink
Copy link
Contributor Author

/remove-lifecycle stale

@k8s-ci-robot k8s-ci-robot removed the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Dec 15, 2020
@fejta-bot
Copy link

Issues go stale after 90d of inactivity.
Mark the issue as fresh with /remove-lifecycle stale.
Stale issues rot after an additional 30d of inactivity and eventually close.

If this issue is safe to close now please do so with /close.

Send feedback to sig-contributor-experience at kubernetes/community.
/lifecycle stale

@k8s-ci-robot k8s-ci-robot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Mar 15, 2021
@basvandenbrink
Copy link
Contributor Author

Seems to be fixed by this commit.

@floryut
Copy link
Member

floryut commented Mar 15, 2021

Seems to be fixed by this commit.

Indeed, we forgot to update the issue, sorry for the inconvenience.

@basvandenbrink
Copy link
Contributor Author

No problem. Just for the sake of administration: it is PR #6814.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/bug Categorizes issue or PR as related to a bug. lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale.
Projects
None yet
Development

No branches or pull requests

6 participants