Calico KDD not working

[woopstar]

Calico KDD is currently not working as expected.

#4498 Added initial support for kdd and typha.

But when we install the Calico network plugin we alter the configuration using calicoctl. This alters the etcd cluster setup and NOT kdd, as it needs to update the CRD's using kubectl instead.

A task not working is: https://github.com/kubernetes-sigs/kubespray/blob/master/roles/network_plugin/calico/tasks/install.yml#L95

@grialeyur

[grialeyur]

I'll explore this problem.

[JTabel]

This also prevents upgrades,since the check for calico version is checking with an etcd backend, which does not provide any cluster version. See:

kubespray/roles/network_plugin/calico/tasks/check.yml

Lines 18 to 21 in 88d9193

	ETCD_ENDPOINTS: "{{ etcd_access_addresses }}"
	ETCD_CA_CERT_FILE: "{{ calico_cert_dir }}/ca_cert.crt"
	ETCD_CERT_FILE: "{{ calico_cert_dir }}/cert.crt"
	ETCD_KEY_FILE: "{{ calico_cert_dir }}/key.pem"

[woopstar]

@grialeyur any updates on this?

[JTabel]

I have a possible solution by using the calicoctl wrapper script in 2 different versions and actually use it for the version check. This way it is a minimal code change but should have the desired results. I will be testing this shortly to see if it works.

[xeor]

Not 100% sure if this is related, but I think so.
When trying to upgrade a cluster I use kdd on, I'm getting

TASK [kubernetes/preinstall : Check that calico version is enough for upgrade] *****************************************************************
Saturday 29 June 2019 23:21:26 +0200 (0:00:00.337) 0:00:25.211 *********
fatal: [d0]: FAILED! => {
"assertion": "calico_version_on_server.stdout is version('v2.6.5', '>=')",
"changed": false,
"evaluated_to": false,
"msg": "Your version of calico is not fresh enough for upgrade. Minimum version v2.6.5"
}

Is this related? The bin_dir it looks for calicoctl.sh is /usr/local/bin. But I have successfully upgraded this before I started using kdd..