Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

upgrade: variables modified in kubeadm-config.yaml are not reflected in static manifests anymore #11552

Open
maxime1907 opened this issue Sep 19, 2024 · 4 comments · May be fixed by #11871
Open

upgrade: variables modified in kubeadm-config.yaml are not reflected in static manifests anymore #11552

maxime1907 opened this issue Sep 19, 2024 · 4 comments · May be fixed by #11871
Labels
kind/bug Categorizes issue or PR as related to a bug.

Comments

@maxime1907
Copy link
Contributor

maxime1907 commented Sep 19, 2024 •
edited
Loading

What happened?

Recently, the --config option was removed from kubeadm upgrade following deprecation cycle:

This introduces a regression because now there is no playbook to reconfigure kubeadm

What did you expect to happen?

upgrade-cluster.yml playbook reconfigures kubeadm

How can we reproduce it (as minimally and precisely as possible)?

  1. Deploy a cluster
  2. Change a kubeadm setting like kube_apiserver_pod_eviction_not_ready_timeout_seconds
  3. Run the upgrade playbook

OS

Linux 5.15.0-122-generic x86_64
PRETTY_NAME="Ubuntu 22.04.3 LTS"
NAME="Ubuntu"
VERSION_ID="22.04"
VERSION="22.04.3 LTS (Jammy Jellyfish)"
VERSION_CODENAME=jammy
ID=ubuntu
ID_LIKE=debian
HOME_URL="https://www.ubuntu.com/"
SUPPORT_URL="https://help.ubuntu.com/"
BUG_REPORT_URL="https://bugs.launchpad.net/ubuntu/"
PRIVACY_POLICY_URL="https://www.ubuntu.com/legal/terms-and-policies/privacy-policy"
UBUNTU_CODENAME=jammy

Version of Ansible

ansible [core 2.16.10]
  config file = /kubespray/ansible.cfg
  configured module search path = ['/kubespray/library']
  ansible python module location = /usr/local/lib/python3.10/dist-packages/ansible
  ansible collection location = /root/.ansible/collections:/usr/share/ansible/collections
  executable location = /usr/local/bin/ansible
  python version = 3.10.12 (main, Jul 29 2024, 16:56:48) [GCC 11.4.0] (/usr/bin/python3)
  jinja version = 3.1.4
  libyaml = True

Version of Python

Python 3.10.12

Version of Kubespray (commit)

f9ebd45

Network plugin used

calico

Full inventory with variables

not relevant

Command used to invoke ansible

ansible-playbook -i inventory/mycluster/hosts.yaml upgrade-cluster.yml

Output of ansible run

not relevant

Anything else we need to know

I'm not sure if we should completely separate this feature inside a dedicated playbook or reintroduce this behavior with a command such as:

kubeadm init phase control-plane all --config /etc/kubernetes/kubeadm-config.yaml

That topic has been a bit discussed here:
@maxime1907 maxime1907 added the kind/bug Categorizes issue or PR as related to a bug. label Sep 19, 2024
@tico88612
Copy link
Member

This issue is an embarrassment. v1.29 works with --config but v1.30 doesn't, but v1.31 does again.

BTW, reconfiguring clusters is not a good practice.

#11352 (comment)

@tico88612
Copy link
Member

tico88612 commented Oct 16, 2024 •
edited
Loading

@maxime1907 If you want to add this back, we should first support Kubeadm Configuration (v1beta4).

Related Issue: #10935

@1337andre
Copy link

any update on this? we run into this issue. Has anybody worked around it?

k8s 1.30 with kubespray 2.26

@Hector295 Hector295 linked a pull request Jan 8, 2025 that will close this issue
Open
@unai-ttxu
Copy link
Contributor

unai-ttxu commented Jan 28, 2025 •
edited
Loading

The issue also causes the etcd version to remain unchanged after executing the upgrade_cluster.yml playbook when etcd_deployment_type: 'kubeadm'.

Since kubernetes-sigs/kubespray#11352 removed the use of the --config flag to use the updated kubeadm-config.yaml, the etcd pod manifest is not upgraded during the kubeadm upgrade since it will use the kubeadm-config configmap which is not reflecting the new etcd image version.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
kind/bug Categorizes issue or PR as related to a bug.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Feature: Adds reconfigure control plane Hector295/kubespray
6 participants
@unai-ttxu @tico88612 @maxime1907 @1337andre and others