Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

youki default url is wrong #10331

Closed
mrafee113 opened this issue Aug 2, 2023 · 1 comment · Fixed by #10337 or #10346
Closed

youki default url is wrong #10331

mrafee113 opened this issue Aug 2, 2023 · 1 comment · Fixed by #10337 or #10346
Labels
kind/bug Categorizes issue or PR as related to a bug.

Comments

@mrafee113
Copy link

Hello. Sorry to bother you. I figured out a teeny tiny bug in the default variables.
In the file kubespray/roles/download/defaults/main/main.yml, the variable youki_version has the value v0.1.0. In the same file, the variable youki_download_url contains the value /youki_{{ youki_version | regex_replace('\\.', '_' }}_linux.tar.gz". When processed by jinja, this would become /youki_v0_1_0_linux.tar.gz.
The problem is that according the youki github release page, the url to the file should end like this: /youki_0_1_0_linux.tar.gz.
The quick fix I think would be to just add a custom url to the invetories.
I'm a noob at this and not sure if I'm right, so I'm not going to open a merge request, and instead will leave it in your hands.

FYI, I found this out when I generated files.list using kubespray/contrib/offline/generate_list.sh.

Environment:

  • Cloud provider or hardware configuration:
    Asus ROG Strix. (does not really matter in this scenario)

  • OS (printf "$(uname -srm)\n$(cat /etc/os-release)\n"):
    Linux 5.19.0-46-generic x86_64
    PRETTY_NAME="Ubuntu 22.10"
    NAME="Ubuntu"
    VERSION_ID="22.10"
    VERSION="22.10 (Kinetic Kudu)"
    VERSION_CODENAME=kinetic
    ID=ubuntu
    ID_LIKE=debian
    HOME_URL="https://www.ubuntu.com/"
    SUPPORT_URL="https://help.ubuntu.com/"
    BUG_REPORT_URL="https://bugs.launchpad.net/ubuntu/"
    PRIVACY_POLICY_URL="https://www.ubuntu.com/legal/terms-and-policies/privacy-policy"
    UBUNTU_CODENAME=kinetic
    LOGO=ubuntu-logo

  • Version of Ansible (ansible --version):
    ansible [core 2.14.6]
    config file = None
    configured module search path = ['/home/mehdi/.ansible/plugins/modules', '/usr/share/ansible/plugins/modules']
    ansible python module location = /home/mehdi/.local/lib/python3.10/site-packages/ansible
    ansible collection location = /home/mehdi/.ansible/collections:/usr/share/ansible/collections
    executable location = /home/mehdi/.local/bin/ansible
    python version = 3.10.7 (main, May 29 2023, 13:51:48) [GCC 12.2.0] (/usr/bin/python3)
    jinja version = 3.1.2
    libyaml = True

  • Version of Python (python --version):
    3.10.7

Kubespray version (commit) (git rev-parse --short HEAD):
36e5d74

Network plugin used:
calico

Full inventory with variables (ansible -i inventory/sample/inventory.ini all -m debug -a "var=hostvars[inventory_hostname]"):

really does not matter here...

Command used to invoke ansible:
ansible-playbook

Output of ansible run:

Haven't run it yet; but still it does not matter here.

@mrafee113 mrafee113 added the kind/bug Categorizes issue or PR as related to a bug. label Aug 2, 2023
@ErikJiang
Copy link
Member

ErikJiang commented Aug 4, 2023

@mrafee113 Thanks for the bug report, I've created a PR for this and you're welcome to review it!😁

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/bug Categorizes issue or PR as related to a bug.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants