-
Notifications
You must be signed in to change notification settings - Fork 1.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add linter for the samples scaffolded under docs #4445
Comments
/assign |
I have a question regarding the task of adding a linter for the samples under the kubebuilder/.github/workflows/lint-sample.yml Lines 15 to 20 in 980fb71
I just want to confirm if this approach is acceptable before proceeding. Thank you for your help! |
Hi @jongwooo Yes, we can just add the path for the docs samples on this one We should not have more than 1 commit for this PR |
I'm going to unassign myself as i clearly don't have the bandwidth to tackle the feature. /unassign |
/assign |
@camilamacedo86 I am so happy and excited to submit my first PR .. looking forward for your reviews :) |
Done ! |
What do you want to happen?
Currently, the samples scaffolded under the docs directory do not have any linting process to ensure consistency and adherence to best practices. This issue proposes adding a linter to verify the quality of the following samples:
We should create an action to lint them as we have for the samples under testdata
See: https://github.com/kubernetes-sigs/kubebuilder/blob/master/.github/workflows/lint-sample.yml
in this task, we need to create the action and fix any linter issue found to ensure that it pass in the CI
Extra Labels
No response
The text was updated successfully, but these errors were encountered: