Merge pull request #631 from CodeLingoBot/rewrite

k8s-ci-robot · web-flow · commit f2c240a57622 · 2019-03-14T16:42:57.000-07:00
Fix function comments based on best practices from Effective Go
diff --git a/test/internal/e2e/kubebuildertest.go b/test/internal/e2e/kubebuildertest.go
@@ -201,7 +201,7 @@ func (kt *KubebuilderTest) RunKubectlCommand(cmdOptions []string) (string, error
 	return string(output), err
 }
 
-// RunKubectlCommand is a general func to run kubectl commands
+// RunKubectlCommandWithInput is a general func to run kubectl commands
 func (kt *KubebuilderTest) RunKubectlCommandWithInput(cmdOptions []string, stdinInput string) (string, error) {
 	cmd := exec.Command("kubectl", cmdOptions...)
 	stdin, err := cmd.StdinPipe()

Original file line number	Diff line number	Diff line change
`@@ -201,7 +201,7 @@ func (kt *KubebuilderTest) RunKubectlCommand(cmdOptions []string) (string, error`
`201`	`201`	`return string(output), err`
`202`	`202`	`}`
`203`	`203`
`204`		`-// RunKubectlCommand is a general func to run kubectl commands`
	`204`	`+// RunKubectlCommandWithInput is a general func to run kubectl commands`
`205`	`205`	`func (kt *KubebuilderTest) RunKubectlCommandWithInput(cmdOptions []string, stdinInput string) (string, error) {`
`206`	`206`	`cmd := exec.Command("kubectl", cmdOptions...)`
`207`	`207`	`stdin, err := cmd.StdinPipe()`