Skip to content

Commit ba0d560

Browse files
authored
Merge pull request #809 from DirectXMan12/feature/properly-use-scheme
Add existing k8s types to new scheme
2 parents 11e1b13 + 148510f commit ba0d560

File tree

2 files changed

+7
-4
lines changed

2 files changed

+7
-4
lines changed

pkg/scaffold/v2/main.go

+4-3
Original file line numberDiff line numberDiff line change
@@ -130,11 +130,12 @@ import (
130130
)
131131
132132
var (
133-
scheme = clientgoscheme.Scheme
134-
setupLog = ctrl.Log.WithName("setup")
133+
scheme = runtime.NewScheme()
134+
setupLog = ctrl.Log.WithName("setup")
135135
)
136136
137137
func init() {
138+
_ = clientgoscheme.AddToScheme(scheme)
138139
139140
%s
140141
}
@@ -160,7 +161,7 @@ func main() {
160161
}
161162
162163
163-
%s
164+
%s
164165
165166
setupLog.Info("starting manager")
166167
if err := mgr.Start(ctrl.SetupSignalHandler()); err != nil {

testdata/project-v2/main.go

+3-1
Original file line numberDiff line numberDiff line change
@@ -21,6 +21,7 @@ import (
2121
"os"
2222

2323
corev1 "k8s.io/api/core/v1"
24+
"k8s.io/apimachinery/pkg/runtime"
2425
clientgoscheme "k8s.io/client-go/kubernetes/scheme"
2526
_ "k8s.io/client-go/plugin/pkg/client/auth/gcp"
2627
ctrl "sigs.k8s.io/controller-runtime"
@@ -31,11 +32,12 @@ import (
3132
)
3233

3334
var (
34-
scheme = clientgoscheme.Scheme
35+
scheme = runtime.NewScheme()
3536
setupLog = ctrl.Log.WithName("setup")
3637
)
3738

3839
func init() {
40+
_ = clientgoscheme.AddToScheme(scheme)
3941

4042
_ = crewv1.AddToScheme(scheme)
4143
_ = corev1.AddToScheme(scheme)

0 commit comments

Comments
 (0)