Skip to content

Commit 8476e7e

Browse files
author
Martin Vladev
committed
Update documentation for client-go informers
- `manager.RunnableFunc` should block or it'll trigger shutdown. - `source.Informer`'s `InformerProvider` field was renamed to `Informer`
1 parent e904181 commit 8476e7e

File tree

1 file changed

+2
-1
lines changed

1 file changed

+2
-1
lines changed

docs/book/beyond_basics/using_client_go_informers.md

+2-1
Original file line numberDiff line numberDiff line change
@@ -24,6 +24,7 @@ generatedInformers := kubeinformers.NewSharedInformerFactory(generatedClient, ti
2424

2525
err := mgr.Add(manager.RunnableFunc(func(s <-chan struct{}) error {
2626
generatedInformers.Start(s)
27+
<- s
2728
return nil
2829
}))
2930
if err != nil {
@@ -50,7 +51,7 @@ The generated InformerFactory must be manually wired into the Controller creatio
5051
```go
5152
// Setup Watch using the client-go generated Informer
5253
err := ctrl.Watch(
53-
&source.Informer{InformerProvider: generatedInformers.Core().V1().Services()},
54+
&source.Informer{Informer: generatedInformers.Core().V1().Services()},
5455
&handler.EnqueueRequestForObject{},
5556
)
5657
if err != nil {

0 commit comments

Comments
 (0)