fix: golangci-lint passes against a new project

Previously:

deadcode (via golangci-lint) reported:
```
controllers/suite_test.go:23:5: `cfg` is unused (deadcode)
var cfg *rest.Config
    ^
```

errcheck (via golangci-lint) reported:

```
main.go:27:26: Error return value of `nrdbv1alpha1.AddToScheme` is not checked (errcheck)
	nrdbv1alpha1.AddToScheme(scheme)
	                        ^
```

Also add a guardrail or two to the generated_golden.sh script, as it was
not immediately obvious what to do about tar's complaint that it
couldn't recognize the file format.

Author: sethp-nr

generated_golden.sh

@@ -33,7 +33,7 @@ scaffold_test_project() {
 	testdata_dir=$(pwd)/testdata
 	mkdir -p ./testdata/$project
 	rm -rf ./testdata/$project/*
-	pushd . 
+	pushd .
 	cd testdata/$project
 
 	kb=$testdata_dir/../bin/kubebuilder
@@ -79,6 +79,13 @@ scaffold_test_project() {
 }
 
 set -e
+
+if ! git lfs > /dev/null 2>&1 ; then
+    echo "this project requires git-lfs, see: https://git-lfs.github.com/"
+    echo "after installing, you'll need to git checkout ./testdata/*tgz"
+    exit 1
+fi
+
 build_kb
 scaffold_test_project gopath/src/project 1
 scaffold_test_project project-v2 2

pkg/scaffold/v2/controller_suitetest.go

@@ -103,8 +103,9 @@ var _ = BeforeSuite(func(done Done) {
 	testEnv = &envtest.Environment{
 		CRDDirectoryPaths: []string{filepath.Join("..", "config", "crd", "bases")},
 	}
-	
-	cfg, err := testEnv.Start()
+
+	var err error
+	cfg, err = testEnv.Start()
 	Expect(err).ToNot(HaveOccurred())
 	Expect(cfg).ToNot(BeNil())
 

pkg/scaffold/v2/main.go

@@ -62,7 +62,7 @@ func (m *Main) Update(opts *MainUpdateOptions) error {
 `, opts.Resource.Group, opts.Resource.Version, resPkg, opts.Resource.Version)
 	ctrlImportCodeFragment := fmt.Sprintf(`"%s/controllers"
 `, opts.Project.Repo)
-	addschemeCodeFragment := fmt.Sprintf(`%s%s.AddToScheme(scheme)
+	addschemeCodeFragment := fmt.Sprintf(`_ = %s%s.AddToScheme(scheme)
 `, opts.Resource.Group, opts.Resource.Version)
 	reconcilerSetupCodeFragment := fmt.Sprintf(`err = (&controllers.%sReconciler{
 	 	Client: mgr.GetClient(),

testdata/project-v2/controllers/suite_test.go

@@ -57,7 +57,8 @@ var _ = BeforeSuite(func(done Done) {
 		CRDDirectoryPaths: []string{filepath.Join("..", "config", "crd", "bases")},
 	}
 
-	cfg, err := testEnv.Start()
+	var err error
+	cfg, err = testEnv.Start()
 	Expect(err).ToNot(HaveOccurred())
 	Expect(cfg).ToNot(BeNil())
 

testdata/project-v2/main.go

@@ -37,8 +37,8 @@ var (
 
 func init() {
 
-	crewv1.AddToScheme(scheme)
-	corev1.AddToScheme(scheme)
+	_ = crewv1.AddToScheme(scheme)
+	_ = corev1.AddToScheme(scheme)
 	// +kubebuilder:scaffold:scheme
 }