Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add details to Test_fetchLatestTag_GitHubAPI #516

Closed
ahmetb opened this issue Feb 27, 2020 · 1 comment · Fixed by #518
Closed

add details to Test_fetchLatestTag_GitHubAPI #516

ahmetb opened this issue Feb 27, 2020 · 1 comment · Fixed by #518

Comments

@ahmetb
Copy link
Member

ahmetb commented Feb 27, 2020 

--- FAIL: Test_fetchLatestTag_GitHubAPI (0.16s)
    fetch_tag_test.go:29: Expected a latest tag in the response
FAIL

This test is very frequently failing on Travis CI.

I'm guessing because of GitHub API rate limits exposed to pool of Travis CI machines. Surprisingly works fine on GitHub Actions, however.

Maybe it'd be ideal if we add some message to the error so we can see what's going on.
@corneliusweig
Copy link
Contributor

Yes, this is on my todo list. I'll try to get to it later today.

@corneliusweig corneliusweig mentioned this issue Feb 27, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Consider HTTP status for more meaningful errors corneliusweig/krew
2 participants
@ahmetb @corneliusweig