Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

hack: run-lint.sh needs to be migrated to go modules #267

Closed
ahmetb opened this issue Jul 17, 2019 · 0 comments · Fixed by #268
Closed

hack: run-lint.sh needs to be migrated to go modules #267

ahmetb opened this issue Jul 17, 2019 · 0 comments · Fixed by #268
Labels
kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. priority/backlog Higher priority than priority/awaiting-more-evidence.

Comments

@ahmetb
Copy link
Member

ahmetb commented Jul 17, 2019

run-lint.sh currently uses $GOPATH variable directly.
Instead it should use go env GOPATH.

/kind cleanup
/priority backlog
@k8s-ci-robot k8s-ci-robot added kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. priority/backlog Higher priority than priority/awaiting-more-evidence. labels Jul 17, 2019
@ahmetb ahmetb mentioned this issue Jul 17, 2019
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. priority/backlog Higher priority than priority/awaiting-more-evidence.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

hack: make run-lint.sh work with go modules ahmetb/krew
2 participants
@ahmetb @k8s-ci-robot