Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for configurable HTTP redirects #200

Closed
hbagdi opened this issue May 22, 2020 · 7 comments · Fixed by #683
Closed

Add support for configurable HTTP redirects #200

hbagdi opened this issue May 22, 2020 · 7 comments · Fixed by #683
Assignees
Labels
kind/feature Categorizes issue or PR as related to a new feature. lifecycle/frozen Indicates that an issue or PR should not be auto-closed due to staleness. priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release.
Milestone

Comments

@hbagdi
Copy link
Contributor

hbagdi commented May 22, 2020

What would you like to be added:

On a per route basis, a user can configure HTTP redirects 301/302 (may be 307/308 too?) and the location of where to redirect to. It could be simply a redirect to HTTPS, in which case, redirect with the Location header matching the URL of the request being processed or it could be a redirect to a different location. The second part can get tricky because that can invovle path munging (we could consider that to be an extended/custom API).

Why is this needed:

This is a common requirement and most controllers already support this using annotations.

@jpeach
Copy link
Contributor

jpeach commented Jun 2, 2020

@hbagdi One idea I had for this was a special syntax for route selectors (e.g. .wellknown namespace names). That can work for simple http->https cases, but probably doesn't scale for arbitrary redirects.

@hbagdi
Copy link
Contributor Author

hbagdi commented Jun 11, 2020

/assign

@fejta-bot
Copy link

Issues go stale after 90d of inactivity.
Mark the issue as fresh with /remove-lifecycle stale.
Stale issues rot after an additional 30d of inactivity and eventually close.

If this issue is safe to close now please do so with /close.

Send feedback to sig-testing, kubernetes/test-infra and/or fejta.
/lifecycle stale

@k8s-ci-robot k8s-ci-robot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Sep 9, 2020
@hbagdi hbagdi added this to the v1alpha2 milestone Sep 10, 2020
@jpeach
Copy link
Contributor

jpeach commented Sep 10, 2020

/remove-lifecycle stale

@k8s-ci-robot k8s-ci-robot removed the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Sep 10, 2020
@fejta-bot
Copy link

Issues go stale after 90d of inactivity.
Mark the issue as fresh with /remove-lifecycle stale.
Stale issues rot after an additional 30d of inactivity and eventually close.

If this issue is safe to close now please do so with /close.

Send feedback to sig-testing, kubernetes/test-infra and/or fejta.
/lifecycle stale

@k8s-ci-robot k8s-ci-robot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Dec 9, 2020
@robscott
Copy link
Member

robscott commented Dec 9, 2020

/remove-lifecycle stale

@k8s-ci-robot k8s-ci-robot removed the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Dec 9, 2020
@hbagdi
Copy link
Contributor Author

hbagdi commented Dec 9, 2020

/lifecycle frozen
/assign

@k8s-ci-robot k8s-ci-robot added the lifecycle/frozen Indicates that an issue or PR should not be auto-closed due to staleness. label Dec 9, 2020
@robscott robscott added the priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. label May 5, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/feature Categorizes issue or PR as related to a new feature. lifecycle/frozen Indicates that an issue or PR should not be auto-closed due to staleness. priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants