From 3d343ae2961255aea9a1baf1201977413189bd91 Mon Sep 17 00:00:00 2001 From: Mac Chaffee Date: Tue, 9 Aug 2022 11:49:05 -0400 Subject: [PATCH] Changed the Deployment strategy to 'Recreate' so multiple external-dns pods don't conflict with each other. Signed-off-by: Mac Chaffee --- charts/external-dns/README.md | 1 + charts/external-dns/templates/deployment.yaml | 2 ++ charts/external-dns/values.yaml | 3 +++ 3 files changed, 6 insertions(+) diff --git a/charts/external-dns/README.md b/charts/external-dns/README.md index cd6be88bea..0bd75c5592 100644 --- a/charts/external-dns/README.md +++ b/charts/external-dns/README.md @@ -69,3 +69,4 @@ The following table lists the configurable parameters of the _ExternalDNS_ chart | `domainFilters` | Limit possible target zones by domain suffixes. | `[]` | | `provider` | DNS provider where the DNS records will be created, for the available providers and how to configure them see the [README](https://github.com/kubernetes-sigs/external-dns#deploying-to-a-cluster). | `aws` | | `extraArgs` | Extra arguments to pass to the _external-dns_ container, these are needed for provider specific arguments. | `[]` | +| `deploymentStrategy` | .spec.strategy of the external-dns Deployment. Defaults to 'Recreate' since multiple external-dns pods may conflict with each other. | `{type: Recreate}` | diff --git a/charts/external-dns/templates/deployment.yaml b/charts/external-dns/templates/deployment.yaml index 4dbbdb8f2a..1ed3b6f5f6 100644 --- a/charts/external-dns/templates/deployment.yaml +++ b/charts/external-dns/templates/deployment.yaml @@ -14,6 +14,8 @@ spec: selector: matchLabels: {{- include "external-dns.selectorLabels" . | nindent 6 }} + strategy: + {{- toYaml .Values.deploymentStrategy | nindent 4 }} template: metadata: labels: diff --git a/charts/external-dns/values.yaml b/charts/external-dns/values.yaml index a9b3b59e88..988677fbd3 100644 --- a/charts/external-dns/values.yaml +++ b/charts/external-dns/values.yaml @@ -125,3 +125,6 @@ domainFilters: [] provider: aws extraArgs: [] + +deploymentStrategy: + type: Recreate