Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve Cloudflare provider 'registry_errors_total' metric #4081

Closed
danie1sullivan opened this issue Nov 30, 2023 · 0 comments · Fixed by #4082
Closed

Improve Cloudflare provider 'registry_errors_total' metric #4081

danie1sullivan opened this issue Nov 30, 2023 · 0 comments · Fixed by #4082
Labels
kind/feature Categorizes issue or PR as related to a new feature.

Comments

@danie1sullivan
Copy link
Contributor

What would you like to be added:

The Cloudflare provider should increment external_dns_registry_errors_total when changes cannot be submitted (found, updated, deleted, or created).

Currently all of these errors do not get added to external_dns_registry_errors_total because the errors don't get returned.

The counter relies on the error being returned here.

Why is this needed:

Without this, the metric only catches a subset of issues and I have to supplement with log monitoring.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
kind/feature Categorizes issue or PR as related to a new feature.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: include cloudflare error in metrics and logs danie1sullivan/external-dns
1 participant
@danie1sullivan