Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

No way to specify runtime-handler in crictl. #382

Closed
Random-Liu opened this issue Sep 14, 2018 · 0 comments
Closed

No way to specify runtime-handler in crictl. #382

Random-Liu opened this issue Sep 14, 2018 · 0 comments
Labels
kind/feature Categorizes issue or PR as related to a new feature.

Comments

@Random-Liu
Copy link
Contributor

Random-Liu commented Sep 14, 2018 •
edited
Loading

runtime-handler is not part of sandbox config. https://github.com/kubernetes/kubernetes/blob/master/pkg/kubelet/apis/cri/runtime/v1alpha2/api.proto#L353

We should add a separate flag for it, e.g. crictl runp --runtime=kata sandbox.json.

/cc @yujuhong @tallclair
@Random-Liu Random-Liu added the kind/feature Categorizes issue or PR as related to a new feature. label Sep 14, 2018
@Random-Liu Random-Liu mentioned this issue Sep 14, 2018
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
kind/feature Categorizes issue or PR as related to a new feature.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@Random-Liu