Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ClusterClass: MachineHealthChecks should also have topology-owned label #9134

Closed
sbueringer opened this issue Aug 7, 2023 · 4 comments · Fixed by #9191
Closed

ClusterClass: MachineHealthChecks should also have topology-owned label #9134

sbueringer opened this issue Aug 7, 2023 · 4 comments · Fixed by #9191
Assignees
@chaunceyjiang
Labels
area/machinehealthcheck Issues or PRs related to machinehealthchecks triage/accepted Indicates an issue or PR is ready to be actively worked on.

Comments

@sbueringer
Copy link
Member

Today almost all objects created by the topology controller have the topology-owned label. The only exception are the MachineHealthChecks. Let's also add the label to them
@sbueringer sbueringer added the area/machinehealthcheck Issues or PRs related to machinehealthchecks label Aug 7, 2023
@k8s-ci-robot k8s-ci-robot added the needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. label Aug 7, 2023
@sbueringer
Copy link
Member Author

/triage accepted

@k8s-ci-robot k8s-ci-robot added triage/accepted Indicates an issue or PR is ready to be actively worked on. and removed needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. labels Aug 7, 2023
@sbueringer
Copy link
Member Author

/assign

@chaunceyjiang
Copy link
Contributor

@sbueringer Hi, I'm sorry to bother you. Have you started working on this issue? If you haven't started yet, can I pick up this task?

@sbueringer
Copy link
Member Author

Thx for asking, no worries. Didn't start yet

/assign @chaunceyjiang
/unassign

@chaunceyjiang chaunceyjiang mentioned this issue Aug 15, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@chaunceyjiang chaunceyjiang

Labels
area/machinehealthcheck Issues or PRs related to machinehealthchecks triage/accepted Indicates an issue or PR is ready to be actively worked on.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

🐛 Add topology-owned label to MachineHealthChecks. chaunceyjiang/cluster-api
3 participants
@sbueringer @chaunceyjiang @k8s-ci-robot