Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow to configure garbage collector using clusterawsadm #4513

Closed
Fedosin opened this issue Sep 22, 2023 · 1 comment · Fixed by #4500
Closed

Allow to configure garbage collector using clusterawsadm #4513

Fedosin opened this issue Sep 22, 2023 · 1 comment · Fixed by #4500
Labels
kind/feature Categorizes issue or PR as related to a new feature. needs-priority needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one.

Comments

@Fedosin
Copy link
Contributor

Fedosin commented Sep 22, 2023

/kind feature

Describe the solution you'd like
Recently we added a possibility to configure garbage collector for AWS clusters: #4466 To do so we need to set an annotation for the related AWSCluster object. It's not convenient to do it manually, so I'd like to let clusterawsadm cli tool to do it for me.

It should be implemented under clusterawsadm gc configure section, where users can add or remove GC tasks for a specific cluster. For example:

# Enable load-balancer and security-group tasks, target-group will be disabled.
clusterawsadm gc configure --cluster-name=cluster --gc-task load-balancer --gc-task security-group
# Reset configuration (remove the annotation)
clusterawsadm gc configure --cluster-name=cluster

Environment:

  • Cluster-api-provider-aws version:
  • Kubernetes version: (use kubectl version):
  • OS (e.g. from /etc/os-release):
@k8s-ci-robot k8s-ci-robot added kind/feature Categorizes issue or PR as related to a new feature. needs-priority labels Sep 22, 2023
@k8s-ci-robot
Copy link
Contributor

This issue is currently awaiting triage.

If CAPA/CAPI contributors determines this is a relevant issue, they will accept it by applying the triage/accepted label and provide further guidance.

The triage/accepted label can be added by org members by writing /triage accepted in a comment.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added the needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. label Sep 22, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/feature Categorizes issue or PR as related to a new feature. needs-priority needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants