Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Spot Instance Support for AWSManagedMachinePool #2523

Closed
cabrinha opened this issue Jun 18, 2021 · 14 comments · Fixed by #3523
Closed

Spot Instance Support for AWSManagedMachinePool #2523

cabrinha opened this issue Jun 18, 2021 · 14 comments · Fixed by #3523
Labels
kind/feature Categorizes issue or PR as related to a new feature. lifecycle/frozen Indicates that an issue or PR should not be auto-closed due to staleness. priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release.

Comments

@cabrinha
Copy link

/kind feature

Describe the solution you'd like
I'd like to use AWSManagedMachinePool / MachinePool with spot instances.

Environment:

  • Cluster-api-provider-aws version: v6.5.0
  • Kubernetes version: (use kubectl version): v1.19
  • OS (e.g. from /etc/os-release): amazon linux 2
@k8s-ci-robot k8s-ci-robot added kind/feature Categorizes issue or PR as related to a new feature. needs-priority labels Jun 18, 2021
@voor
Copy link
Member

voor commented Jul 7, 2021

@k8s-triage-robot
Copy link

The Kubernetes project currently lacks enough contributors to adequately respond to all issues and PRs.

This bot triages issues and PRs according to the following rules:

  • After 90d of inactivity, lifecycle/stale is applied
  • After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
  • After 30d of inactivity since lifecycle/rotten was applied, the issue is closed

You can:

  • Mark this issue or PR as fresh with /remove-lifecycle stale
  • Mark this issue or PR as rotten with /lifecycle rotten
  • Close this issue or PR with /close
  • Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/lifecycle stale

@k8s-ci-robot k8s-ci-robot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Oct 5, 2021
@voor
Copy link
Member

voor commented Oct 5, 2021

/remove-lifecycle stale

@k8s-ci-robot k8s-ci-robot removed the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Oct 5, 2021
@richardcase
Copy link
Member

/priority important-soon
/milestone v1.x

@k8s-ci-robot k8s-ci-robot added this to the v1.x milestone Nov 29, 2021
@k8s-ci-robot k8s-ci-robot added priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. and removed needs-priority labels Nov 29, 2021
@richardcase
Copy link
Member

/triage accapted

@k8s-triage-robot
Copy link

The Kubernetes project currently lacks enough contributors to adequately respond to all issues and PRs.

This bot triages issues and PRs according to the following rules:

  • After 90d of inactivity, lifecycle/stale is applied
  • After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
  • After 30d of inactivity since lifecycle/rotten was applied, the issue is closed

You can:

  • Mark this issue or PR as fresh with /remove-lifecycle stale
  • Mark this issue or PR as rotten with /lifecycle rotten
  • Close this issue or PR with /close
  • Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/lifecycle stale

@k8s-ci-robot k8s-ci-robot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Feb 27, 2022
@richardcase
Copy link
Member

/lifecycle frozen

@k8s-ci-robot k8s-ci-robot added lifecycle/frozen Indicates that an issue or PR should not be auto-closed due to staleness. and removed lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. labels Mar 15, 2022
@pydctw
Copy link
Contributor

pydctw commented Jun 10, 2022

Spot Instance support is already available with AWSManagedMachinePool + MachinePool flavor (EKS cluster) by specifying capacityType in AWSManagedMachinePool spec.

apiVersion: infrastructure.cluster.x-k8s.io/v1beta1
kind: AWSManagedMachinePool
metadata:
  name: eks-pool-0
spec:
  capacityType: spot
  ...

What are remaining tasks for the issue? (I may lack context on this, hence asking)

@Ankitasw
Copy link
Member

Correct me if I am wrong but I think this is the ask here.

@pydctw
Copy link
Contributor

pydctw commented Jun 10, 2022

After reading the proposal, I am still not clear what else is needed for spot instance support in EKS managed node group case (with AWSManagedMachinePool). Could you help elaborate, @Ankitasw?

@pydctw
Copy link
Contributor

pydctw commented Jun 10, 2022

/retitle Spot Instance Support for AWSManagedMachinePool

@k8s-ci-robot k8s-ci-robot changed the title Spot Instance Support Spot Instance Support for AWSManagedMachinePool Jun 10, 2022
@AustinSiu
Copy link

@pydctw if this issue is scoped to just AWSManagedMachinePools, do you know what is the state of Spot support in AWSMachinePools/non-managed case? From the CAPA book, I had assumed this issue was tracking both (wasn't aware of the existing EKS support!).

@pydctw
Copy link
Contributor

pydctw commented Jun 13, 2022

We discussed spot instance support in CAPA during 6/13/22 office hr. Decided to create a new issue for AWSMachinePool spot instance support.

@pydctw
Copy link
Contributor

pydctw commented Jun 13, 2022

I will create a PR to update spot instance doc with AWSManagedMachinePool.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/feature Categorizes issue or PR as related to a new feature. lifecycle/frozen Indicates that an issue or PR should not be auto-closed due to staleness. priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

8 participants