Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add EBS-backed Ephemeral Volume example to documentation #2310

Merged

Conversation

AndrewSirenko
Copy link
Contributor

What type of PR is this?

/kind documentation

What is this PR about? / Why do we need it?

Add EBS-backed Ephemeral Volume example to documentation to better support users like those in #1964.

How was this change tested?

Worked through example

Does this PR introduce a user-facing change?

Add EBS-backed Generic Ephemeral Volume example

@k8s-ci-robot k8s-ci-robot added kind/documentation Categorizes issue or PR as related to documentation. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Jan 24, 2025
@k8s-ci-robot k8s-ci-robot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Jan 24, 2025
Copy link

Code Coverage Diff

This PR does not change the code coverage

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jan 27, 2025
@ElijahQuinones
Copy link
Member

Ran through example on test cluster and confirmed it works as intended

❯ kubectl apply -f mans
pod/app created
storageclass.storage.k8s.io/ebs-ephemeral-demo created

❯ kubectl get pvc app-persistent-storage
NAME                     STATUS   VOLUME                                     CAPACITY   ACCESS MODES   STORAGECLASS         VOLUMEATTRIBUTESCLASS   AGE
app-persistent-storage   Bound    pvc-56216e78-f3e7-4319-a3b2-b83035258d4f   1Gi        RWO            ebs-ephemeral-demo   <unset>                 73s

❯ kubectl exec app -- cat /data/out.txt
Mon Jan 27 16:54:16 UTC 2025
Mon Jan 27 16:54:21 UTC 2025
Mon Jan 27 16:54:26 UTC 2025
Mon Jan 27 16:54:31 UTC 2025
Mon Jan 27 16:54:36 UTC 2025
Mon Jan 27 16:54:41 UTC 2025
Mon Jan 27 16:54:46 UTC 2025
Mon Jan 27 16:54:51 UTC 2025
Mon Jan 27 16:54:56 UTC 2025
Mon Jan 27 16:55:01 UTC 2025
Mon Jan 27 16:55:06 UTC 2025
Mon Jan 27 16:55:11 UTC 2025
Mon Jan 27 16:55:16 UTC 2025
Mon Jan 27 16:55:21 UTC 2025
Mon Jan 27 16:55:26 UTC 2025

❯ kubectl delete -f mans
pod "app" deleted
storageclass.storage.k8s.io "ebs-ephemeral-demo" deleted

❯ kubectl get pvc app-persistent-storage
Error from server (NotFound): persistentvolumeclaims "app-persistent-storage" not found

❯ kubectl get pv pvc-56216e78-f3e7-4319-a3b2-b83035258d4f
Error from server (NotFound): persistentvolumes "pvc-56216e78-f3e7-4319-a3b2-b83035258d4f" not found

/lgtm

minus the one minor nit

@k8s-ci-robot k8s-ci-robot removed the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jan 27, 2025
@ElijahQuinones
Copy link
Member

ElijahQuinones commented Jan 27, 2025

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jan 27, 2025
@AndrewSirenko
Copy link
Contributor Author

/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: AndrewSirenko, ElijahQuinones

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [AndrewSirenko,ElijahQuinones]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jan 27, 2025
@k8s-ci-robot k8s-ci-robot merged commit 20de417 into kubernetes-sigs:master Jan 27, 2025
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/documentation Categorizes issue or PR as related to documentation. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants