-
Notifications
You must be signed in to change notification settings - Fork 813
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update metrics to align with Prometheus best practices #2248
Update metrics to align with Prometheus best practices #2248
Conversation
Signed-off-by: torredil <torredil@amazon.com>
Signed-off-by: torredil <torredil@amazon.com>
Code Coverage Diff
|
b270857
to
4060d93
Compare
cc: @SuperQ |
b22ca7f
to
4afddd6
Compare
Signed-off-by: torredil <torredil@amazon.com>
4afddd6
to
ca9a65b
Compare
ca9a65b
to
9b843c7
Compare
9b843c7
to
91f3d73
Compare
/approve |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: ConnorJC3 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/LGTM all metrics in seconds
Signed-off-by: torredil <torredil@amazon.com> Co-authored-by: Connor Catlett <conncatl@amazon.com>
91f3d73
to
212f289
Compare
/lgtm |
What type of PR is this?
/kind cleanup
What is this PR about? / Why do we need it?
This PR updates the metrics registered by the node plugin to align with Prometheus best practices by:
aws_ebs_csi
namespace prefix._total
suffix for counter metrics.It also introduces a new parameter
controller.deprecatedMetrics
to disable registering the existing controller metrics that use an outdated namespace, such as:Metrics using the new namespace will be registered by default if
controller.enableMetrics
is configured:How was this change tested?
make verify && make test
Does this PR introduce a user-facing change?
Note for reviewers:
Please note that time units have been changed from microseconds to seconds for all counters. The read/write IO latency histograms is observed in microseconds (the buckets for these histograms are retrieved directly from the log page which record the data in microseconds).