Inject volumeWaitParameters dependency #2022
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
k8s-ci-robot
added
the
cncf-cla: yes
k8s-ci-robot
added
the
size/L
|
/hold Will rebase once #2021 is merged. |
k8s-ci-robot
added
the
do-not-merge/hold
Code Coverage DiffThis PR does not change the code coverage |
rdpsin
reviewed
Apr 24, 2024
AndrewSirenko
force-pushed
the
injectWait
branch
2 times, most recently
from
4d5fff5 to
8835f3a
Compare
|
/unhold Merged #2021, rebased this PR with new backoff Cap. |
k8s-ci-robot
removed
the
do-not-merge/hold
ConnorJC3
reviewed
Apr 26, 2024
|
/retest |
k8s-ci-robot
added
the
lgtm
|
/approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: ConnorJC3 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
the
approved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Is this a bug fix or adding new feature?
Improvement
What is this PR about? / Why do we need it?
Today, we sleep in cloud package tests due to hardcoding volume polling parameters inside
waitForfunctions likewaitForVolumeThis PR:
volumeWaitParameters.gofileNote: Will rebase once #2021 is merged.
What testing is done?
make test