-
Notifications
You must be signed in to change notification settings - Fork 813
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix relationship between node service and mounter interface #1997
Fix relationship between node service and mounter interface #1997
Conversation
Code Coverage Diff
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Few initial questions/comments, will review once more when unit tests are ready. Thanks for this!
7e4089b
to
b090dc2
Compare
/retest |
b090dc2
to
bd4b87d
Compare
/retest |
f974271
to
a993baa
Compare
edf4395
to
88e5cd6
Compare
f3da9b4
to
5d75342
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
Signed-off-by: torredil <torredil@amazon.com>
5d75342
to
fe51533
Compare
/approve Thank you very much for all of the great effort in reviewing all the changes made across the refactoring PRs @ConnorJC3 @AndrewSirenko |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: torredil The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
What is this PR about? / Why do we need it?
This patch is 2/2, designed to improve the architecture of the code base with the goal of promoting a more cohesive and understandable design that makes it easier to reason about the driver and make future modifications or extensions more intuitive.
More specifically, this PR fixes the relationship between the node service and mounter interface, allowing for a platform agnostic node service.
Summary of Changes
resizeFs
functionality into mounter packageNodeStageVolume
andNodeExpandVolume
RPCs to use theResize
method directly from theMounter
interface, instead of creating a newResizeFs
instance.DeviceIdentifier
interfacedeviceIdentifier
with direct calls toos.Lstat
andfilepath.EvalSymlinks
.node_linux.go
andnode_windows.go
tomount_linux.go
andmount_windows.go
.metadata.MetadataService
,Mounter
,metadata.KubernetesAPIClient
) into theNewDriver()
andNewNodeService()
functions.What testing is done?
make test && make verify