Add helm wrapper to convert --reuse-values to --reset-then-reuse-values for CT testing #1957
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
k8s-ci-robot
added
the
cncf-cla: yes
k8s-ci-robot
added
the
size/S
Code Coverage DiffThis PR does not change the code coverage |
ConnorJC3
force-pushed
the
reuse-values-replace
branch
from
4296324 to
9a7511d
Compare
|
/retest |
…es for CT testing Signed-off-by: Connor Catlett <conncatl@amazon.com>
ConnorJC3
force-pushed
the
reuse-values-replace
branch
from
9a7511d to
33746fe
Compare
AndrewSirenko
approved these changes
Mar 11, 2024
k8s-ci-robot
added
the
lgtm
|
/approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: torredil The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
the
approved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is this PR about? / Why do we need it?
Executes #1864 by changing CT to use
--reset-then-reuse-valuesinstead of--reuse-valuesCurrently this is done via a workaround until helm/chart-testing#531 or similar is merged, I will likely be submitting our own PR to
chart-testingto add the ability to switch the upgrade method, but this will workaround that in our e2e tests and CI until such a feature is released.What testing is done?
Manually tested + CI