-
Notifications
You must be signed in to change notification settings - Fork 813
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Supply custom image to ebs-csi-driver-test pod via Helm #1928
Supply custom image to ebs-csi-driver-test pod via Helm #1928
Conversation
Code Coverage DiffThis PR does not change the code coverage |
20e9d91
to
7212e7f
Compare
7212e7f
to
1e11cb4
Compare
/lgtm |
/approve |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: torredil The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Unrelated to this PR:
/retest |
Is this a bug fix or adding new feature?
Helm
What is this PR about? / Why do we need it?
Closes #1920
Today, helm-tester.yaml has an hardcoded image which is not modifiable by helm chart.
This PR exposes a value in our helm chart to change the registry or customize the image name/tag.
Note, the repetition of the current kubekins image across helm-tester.yaml and values.yaml will be corrected once we deprecate the use of
--reuse-values
when upgrading our helm chart. See #1864What testing is done?
CI and manual: