Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Supply custom image to ebs-csi-driver-test pod via Helm #1928

Conversation

AndrewSirenko
Copy link
Contributor

Is this a bug fix or adding new feature?
Helm

What is this PR about? / Why do we need it?
Closes #1920

Today, helm-tester.yaml has an hardcoded image which is not modifiable by helm chart.

This PR exposes a value in our helm chart to change the registry or customize the image name/tag.

Note, the repetition of the current kubekins image across helm-tester.yaml and values.yaml will be corrected once we deprecate the use of --reuse-values when upgrading our helm chart. See #1864

What testing is done?

CI and manual:

❯ helm upgrade \
  --install aws-ebs-csi-driver \
  --namespace kube-system \
  ./charts/aws-ebs-csi-driver --dry-run --debug --set helmTester.image="test-image" | grep -i "test-image" -C 5

history.go:56: [debug] getting history for release aws-ebs-csi-driver
....
USER-SUPPLIED VALUES:
helmTester:
  image: test-image
--
...
helmTester:
  image: test-image
...
--
...
spec:
  containers:
    - name: kubetest2
      image: test-image
...


❯ helm upgrade \
  --install aws-ebs-csi-driver \
  --namespace kube-system \
  ./charts/aws-ebs-csi-driver --dry-run --debug  | grep -i "gcr" -C 5

history.go:56: [debug] getting history for release aws-ebs-csi-driver
...
helmTester:
  image: gcr.io/k8s-staging-test-infra/kubekins-e2e:v20231206-f7b83ffbe6-master
...
--
...
spec:
  containers:
    - name: kubetest2
      image: gcr.io/k8s-staging-test-infra/kubekins-e2e:v20231206-f7b83ffbe6-master

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Feb 8, 2024
@k8s-ci-robot k8s-ci-robot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Feb 8, 2024
Copy link

github-actions bot commented Feb 8, 2024

Code Coverage Diff

This PR does not change the code coverage

@AndrewSirenko AndrewSirenko force-pushed the helm-customize-kubekins-image branch from 20e9d91 to 7212e7f Compare February 8, 2024 20:20
@k8s-ci-robot k8s-ci-robot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. and removed size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Feb 8, 2024
@AndrewSirenko AndrewSirenko force-pushed the helm-customize-kubekins-image branch from 7212e7f to 1e11cb4 Compare February 8, 2024 20:22
@k8s-ci-robot k8s-ci-robot added size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. and removed size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Feb 8, 2024
@ConnorJC3
Copy link
Contributor

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Feb 9, 2024
@torredil
Copy link
Member

torredil commented Feb 9, 2024

/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: torredil

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Feb 9, 2024
@torredil
Copy link
Member

torredil commented Feb 9, 2024

Unrelated to this PR:

  , error: exit status 1
  Feb  9 17:56:29.438: INFO: At 2024-02-09 17:46:40 +0000 UTC - event for pod-23c7701e-4f99-43aa-9a9a-6ca33276686d: {kubelet ip-192-168-56-144.us-west-2.compute.internal} FailedMount: MountVolume.Setup failed while expanding volume for volume "pvc-8fb82617-908c-4b12-be30-bde41fa001ba" : Expander.NodeExpand failed to expand the volume : rpc error: code = Internal desc = Could not resize volume "vol-0aed0a4964bba54fc" ("3"):  rpc error: code = Unknown desc = error getting sizemin,sizemax from mount. cmd: Get-Volume -UniqueId "$Env:volumeID" | Get-partition | Get-PartitionSupportedSize | Select SizeMax | ConvertTo-Json, output: Get-PartitionSupportedSize : Failed
  Activity ID: {ccf2b7d6-2dfd-424b-9d92-2bea607970b8}
  At line:1 char:56
  + ...  "$Env:volumeID" | Get-partition | Get-PartitionSupportedSize | Selec ...
  +                                        ~~~~~~~~~~~~~~~~~~~~~~~~~~
      + CategoryInfo          : NotSpecified: (StorageWMI:ROOT/Microsoft/.../MSFT_Partition) [Get-PartitionSupportedSize 
     ], CimException
      + FullyQualifiedErrorId : StorageWMI 4,Get-PartitionSupportedSize
   
  {
      "SizeMax":  null
  }

/retest

@k8s-ci-robot k8s-ci-robot merged commit e607514 into kubernetes-sigs:master Feb 9, 2024
19 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add value on helm chart to customize test pod image
4 participants