Fix integration Test #156
Merged
Fix integration Test #156
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: leakingtapan The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
the
approved
k8s-ci-robot
added
cncf-cla: yes
Pull Request Test Coverage Report for Build 265
💛 - Coveralls |
Pull Request Test Coverage Report for Build 266
💛 - Coveralls |
leakingtapan
force-pushed
the
fix-integration
branch
from
a67b62c to
b56ea8e
Compare
|
lgtm thanks for fix! |
bertinatto
reviewed
Dec 22, 2018
| @@ -521,7 +521,7 @@ func (c *cloud) waitForVolume(ctx context.Context, volumeID string) error { | |||
| case "available": | |||
| return true, nil | |||
| case "creating": | |||
| return false, fmt.Errorf("volume %s is still being created", volumeID) | |||
| return false, nil | |||
There was a problem hiding this comment.
Why do you need to remove the error? Since this is in a wait.Poll loop, it's useful to have the error message in case the condition times out. Otherwise you only get a time out error.
Edit: oh, nevermind! I just noticed that this error is scaling up to wait.Poll.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix issues detect during enabling integration test
Ref #153