Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Helm chart image registries different to kustomize manifests #469

Closed
groodt opened this issue Mar 22, 2020 · 2 comments · Fixed by #475
Closed

Helm chart image registries different to kustomize manifests #469

groodt opened this issue Mar 22, 2020 · 2 comments · Fixed by #475
Labels
kind/bug Categorizes issue or PR as related to a bug.

Comments

@groodt
Copy link
Contributor

groodt commented Mar 22, 2020

/kind bug

What happened?

The Helm chart is referencing images in Dockerhub and quay.io.

The kustomize manifests appear to be referencing images in:
602401143452.dkr.ecr.us-west-2.amazonaws.com/eks

What you expected to happen?
They should be the same presumably?

How to reproduce it (as minimally and precisely as possible)?
Compare the image versions in the Helm chart with the output of
kubectl kustomize "github.com/kubernetes-sigs/aws-ebs-csi-driver/deploy/kubernetes/overlays/stable/?ref=master"

Anything else we need to know?:
I'm happy to submit a fix if necessary.

Environment

  • Kubernetes version (use kubectl version):
  • Driver version:
@k8s-ci-robot k8s-ci-robot added the kind/bug Categorizes issue or PR as related to a bug. label Mar 22, 2020
@krmichel
Copy link
Contributor

I already have a PR to keep the helm chart and the manifest in sync. If @leakingtapan or someone else can tell me which set of images should be used I can update them, if needed, on that PR to fix this.

@leakingtapan
Copy link
Contributor

Let's keep the combination of quay.io (for side car image) and dockerhub (for driver itself). Since ecr is lacking on latest images.
@krmichel

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/bug Categorizes issue or PR as related to a bug.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants