Skip to content
This repository has been archived by the owner on May 6, 2022. It is now read-only.

disable unit test and xbuild in travis #2212

Merged
merged 2 commits into from
Jul 24, 2018
Merged

disable unit test and xbuild in travis #2212

merged 2 commits into from
Jul 24, 2018

Conversation

MHBauer
Copy link
Contributor

@MHBauer MHBauer commented Jul 18, 2018

The pull-service-catalog-unit runs this now.

We don't have to do this, but it's an interesting thought. Probably only saves a few seconds at most.

Belt and suspenders if we leave it on.

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Jul 18, 2018
@k8s-ci-robot k8s-ci-robot requested a review from duglin July 18, 2018 22:06
@k8s-ci-robot k8s-ci-robot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Jul 18, 2018
@k8s-ci-robot k8s-ci-robot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. and removed size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Jul 20, 2018
@MHBauer
Copy link
Contributor Author

MHBauer commented Jul 20, 2018

maybe I tried to make it run too soon
/test pull-service-catalog-xbuild

@krzyzacy
Copy link

/retest

@MHBauer
Copy link
Contributor Author

MHBauer commented Jul 23, 2018

/hold

@k8s-ci-robot k8s-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jul 23, 2018
@MHBauer
Copy link
Contributor Author

MHBauer commented Jul 24, 2018

/test pull-service-catalog-xbuild

1 similar comment
@MHBauer
Copy link
Contributor Author

MHBauer commented Jul 24, 2018

/test pull-service-catalog-xbuild

@MHBauer
Copy link
Contributor Author

MHBauer commented Jul 24, 2018

/hold cancel
/approve

@k8s-ci-robot k8s-ci-robot added approved Indicates a PR has been approved by an approver from all required OWNERS files. and removed do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. labels Jul 24, 2018
@MHBauer
Copy link
Contributor Author

MHBauer commented Jul 24, 2018

/cc @carolynvs @jboyd01

@jeremyrickard
Copy link
Contributor

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Jul 24, 2018
Copy link
Contributor

@carolynvs carolynvs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve

@MHBauer MHBauer changed the title disable unit tests in travis disable unit test and xbuild in travis Jul 24, 2018
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: carolynvs, MHBauer

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot merged commit 1c33d34 into kubernetes-retired:master Jul 24, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm Indicates that a PR is ready to be merged. LGTM1 LGTM2 size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants